feat: support finalizers in workflowMetadata (#10243)

Signed-off-by: jie zhang <zhangjie609610@163.com> Co-authored-by: jie zhang <zhangjie609610@163.com>
argoproj · Dec 18, 2022 · f4a65b1 · f4a65b1
1 parent 6c5b506
commit f4a65b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/workflow/common/convert.go b/workflow/common/convert.go
@@ -79,6 +79,8 @@ func toWorkflow(cronWf wfv1.CronWorkflow, objectMeta metav1.ObjectMeta) *wfv1.Wo
 				wf.Annotations[key] = annotation
 			}
 		}
+
+		wf.Finalizers = append(wf.Finalizers, cronWf.Spec.WorkflowMetadata.Finalizers...)
 	}
 	wf.SetOwnerReferences(append(wf.GetOwnerReferences(), *metav1.NewControllerRef(&cronWf, wfv1.SchemeGroupVersion.WithKind(workflow.CronWorkflowKind))))
 

diff --git a/workflow/common/convert_test.go b/workflow/common/convert_test.go
@@ -22,6 +22,8 @@ spec:
       label1: value1
     annotations:
       annotation2: value2
+    finalizers:
+      - finalizer1
   workflowSpec:
     entrypoint: whalesay
     templates:
@@ -38,6 +40,8 @@ metadata:
     annotation2: value2
     workflows.argoproj.io/scheduled-time: "2021-02-19T10:29:05-08:00"
   creationTimestamp: null
+  finalizers:
+  - finalizer1
   generateName: hello-world-
   labels:
     label1: value1