Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support finalizers in workflowMetadata #10243

Merged
merged 1 commit into from
Dec 18, 2022
Merged

feat: support finalizers in workflowMetadata #10243

merged 1 commit into from
Dec 18, 2022

Conversation

jessonzj
Copy link
Contributor

@jessonzj jessonzj commented Dec 16, 2022 •
edited
Loading

Signed-off-by: jie zhang zhangjie609610@163.com

Feat: support finalizers in workflowMetadata

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

@jasonzhng @jessonzj
support finalizers in workflowMetadata
e8e9802 
Signed-off-by: jie zhang <zhangjie609610@163.com>
@sarabala1979 sarabala1979 merged commit f4a65b1 into argoproj:master Dec 18, 2022
@jessonzj jessonzj deleted the support-finalizer branch December 18, 2022 04:54
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 31, 2023
@jessonzj @jasonzhng @reddymh
feat: support finalizers in workflowMetadata (argoproj#10243)
1c6dd7f 
Signed-off-by: jie zhang <zhangjie609610@163.com>
Co-authored-by: jie zhang <zhangjie609610@163.com>
Signed-off-by: Rajshekar Reddy <reddymh@gmail.com>
@tooptoop4
Copy link
Contributor

curious what u use it for @jessonzj ?

@jessonzj
Copy link
Contributor Author

jessonzj commented Feb 8, 2023

curious what u use it for @jessonzj ?

I need to do something before the workflow is deleted @tooptoop4

@terrytangyuan terrytangyuan mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessonzj @tooptoop4 @sarabala1979 @jasonzhng