ui: getPodName is using v1 by default

[or-shachar]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

I noticed that for some workflows the podName is wrongfully set as the nodeID (which is the v1 format).

This resulted in bad log streaming for running templates. (I thought it was related to #10124 but I think it's a pure UI issue).

Looking at the ts code I saw this condition:

argo-workflows/ui/src/app/shared/pod-name.ts

Line 14 in 0c24ca1

if (version === POD_NAME_V2 && templateName !== '') {

The version here is taken straight from the direct annotation of the workflow:

argo-workflows/ui/src/app/archived-workflows/components/archived-workflow-details/archived-workflow-details.tsx

Line 56 in 133b4a3

const version = annotations[ANNOTATION_KEY_POD_NAME_VERSION];

I think that after cc9d14c we should change the condition so that v2 would be used by default also for UI.

Version

v3.4.5

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

{
  "metadata": {
    "name": "fantastic-rhino",
    "namespace": "argo-workflows",
    "labels": {
      "example": "true"
    }
  },
  "spec": {
    "arguments": {
      "parameters": [
        {
          "name": "message",
          "value": "hello argo"
        }
      ]
    },
    "entrypoint": "argosay",
    "templates": [
      {
        "name": "argosay",
        "inputs": {
          "parameters": [
            {
              "name": "message",
              "value": "{{workflow.parameters.message}}"
            }
          ]
        },
        "container": {
          "name": "main",
          "image": "argoproj/argosay:v2",
          "command": [
            "/argosay"
          ],
          "args": [
            "echo",
            "{{inputs.parameters.message}}"
          ]
        }
      }
    ],
    "ttlStrategy": {
      "secondsAfterCompletion": 300
    },
    "podGC": {
      "strategy": "OnPodCompletion"
    }
  }
}

Logs from the workflow controller

Irrelevant

Logs from in your workflow's wait container

Irrelevant

[juliev0]

@JPZ13 can you take a look?