fix: ui getPodName should use v2 format by default (fixes #11015) #11016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or-shachar
force-pushed
the
11015-getPodNameFix
branch
from
e14b9f1
to
ad6d697
Compare
Signed-off-by: or-shachar <or.shachar@wiz.io>
or-shachar
force-pushed
the
11015-getPodNameFix
branch
from
ad6d697
to
b0c116c
Compare
|
I am surprised that the UI has to reconstruct the podName, that is somewhat alarming. Anyway this looks fine. |
isubasinghe
approved these changes
May 12, 2023
terrytangyuan
approved these changes
May 12, 2023
44 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
May 25, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
) (argoproj#11016) Signed-off-by: or-shachar <or.shachar@wiz.io>
7 tasks
This was referenced Apr 22, 2024
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
) (argoproj#11016) Signed-off-by: or-shachar <or.shachar@wiz.io> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes the UI shows the wrong pod name. Specifically for running pods.
I noticed that this change cc9d14c made pod name format v2 to be default even when the annotation is missing in the backend, but this behavior was never coded into the UI code.
This tries to fix it.
Fixes #11015