-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argo lint
is not case sensitive
#13006
Comments
I could have a look. |
I checked a bit the codebase and it seems that the issues traces to the We could use a json package from However since the edit: |
This seems to be directly available as
In which part of the code? Both But I imagine we can similarly just substitute in the |
Regarding, |
Mmm this line only affects JSON structured inputs though, while most users and OP use YAML |
Sorry my bad I was referring a bit further down where it calls the 'toWorkflowTypeYAML' which invokes the 'toWorkflowTypeJSON'. And in there you can find the jsonpkg calls as well. |
Ah I see on this line. |
…Fixes argoproj#13006 (argoproj#13250) Signed-off-by: Miltiadis Alexis <alexmiltiadis@gmail.com> Co-authored-by: Alan Clucas <alan@clucas.org>
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened/what did you expect to happen?
When attempting to lint a
CronWorkflow
definition file,argo lint
does not detect keys with incorrect capitalisation. If these are applied usingkubectl
, then the cron workflow does not work as expected. Usingargo cron create
works, as this tool appears to correct the capitalisation.See example below, with upper case
U
inschedUle
. I would expectargo lint
to produce an error. Instead it produces the following:Version
v3.5.6
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: