Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inlined/anonymous templates #5105

Closed
alexec opened this issue Feb 14, 2021 · 2 comments · Fixed by #5749
Closed

Inlined/anonymous templates #5105

alexec opened this issue Feb 14, 2021 · 2 comments · Fixed by #5749
Assignees
@alexec
Labels
type/feature Feature request
Milestone
2021 Q3

Comments

@alexec
Copy link
Contributor

alexec commented Feb 14, 2021

Currently, DAGTask and WorkflowStep reference templates. What if they were templates themselves? You could inline templates, which I think would be more user friendly, especially making DataTemplate easier to use with other templates and reducing the need for more powerful templating features (e.g. Sprig templating or WithExpression.
@alexec alexec added the type/feature Feature request label Feb 14, 2021
@simster7
Copy link
Member

Great idea, actually. Argo's version of anonymous functions

@alexec alexec linked a pull request Feb 16, 2021 that will close this issue
feat: Inline templates for DAG - Proof of concept #5112
Closed
@alexec alexec changed the title Inlined templates Inlined/anonymous templates Feb 16, 2021
@alexec
Copy link
Contributor Author

alexec commented Apr 6, 2021

I've started a PoC, would anyone like to take over and drive it to the finish line?

@alexec alexec self-assigned this Apr 22, 2021
@alexec alexec linked a pull request Apr 23, 2021 that will close this issue
feat(controller): Inline templates. Closes #5105 #5749
Merged
@alexec alexec added this to the v3.2 milestone May 10, 2021
alexec added a commit that referenced this issue Aug 3, 2021
@alexec
feat(controller): Inline templates. Closes #5105 (#5749)
ec96415
@sarabala1979 sarabala1979 mentioned this issue Aug 11, 2021
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/feature Feature request
Projects
None yet
Milestone
2021 Q3
2 participants
@simster7 @alexec