-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Inline templates. Closes #5105 #5749
Conversation
alexec
commented
Apr 23, 2021
•
edited
Loading
edited
Codecov Report
@@ Coverage Diff @@
## master #5749 +/- ##
==========================================
+ Coverage 48.50% 48.52% +0.02%
==========================================
Files 260 260
Lines 18746 18754 +8
==========================================
+ Hits 9092 9100 +8
+ Misses 8661 8659 -2
- Partials 993 995 +2
Continue to review full report at Codecov.
|
@jessesuen could I please request your review on this? This is for v3.2, we have not released v3.1, so no hurry. |
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec Quick question about this feature
|
Yes.
No. It is not possible to reference inlined templates, by design.
Yes/no. You can inline a DAG within a DAG, or steps within steps etc, but there is the limitation is a single inline. |
Can we add validation for this?
Can we restrict with leaf template types like 'container |
I don't think we need to do this for MVP. But later on, maybe.
Again, I don't think we need this for MVP. |
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>