Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace install does not support CronWorkflows #5841

Closed
christopheblin opened this issue May 6, 2021 · 3 comments
Closed

namespace install does not support CronWorkflows #5841

christopheblin opened this issue May 6, 2021 · 3 comments
Labels

Comments

@christopheblin
Copy link
Contributor

Summary

What happened/what you expected to happen?

I use https://github.com/argoproj/argo-workflows/blob/stable/manifests/namespace-install.yaml (just changing auth-mode to server and adding an ingress with basic auth) and I try to open https://my-ingress-url/cron-workflows

Unsuccessful HTTP response: cronworkflows.argoproj.io is forbidden: User "system:serviceaccount:staging-argo:argo-server" cannot list resource "cronworkflows" in API group "argoproj.io" at the cluster scope

Diagnostics

What Kubernetes provider are you using? AKS

What version of Argo Workflows are you running? latest

argo-server should not try to list cronworkflows at cluster level when it is run with --namespaced


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@Radolumbo
Copy link
Contributor

I can take this one. It's a one-liner change.

@Radolumbo
Copy link
Contributor

See #5846

With this change, the state's namespace in the constructor now matches that in workflows-list: https://github.com/argoproj/argo-workflows/blob/master/ui/src/app/workflows/components/workflows-list/workflows-list.tsx#L114

(Same changes made to similar "list" pages in this PR: https://github.com/argoproj/argo-workflows/pull/5729/files)

@alexec alexec closed this as completed in e332be5 May 6, 2021
@christopheblin
Copy link
Contributor Author

Hello,

Does it mean that in next argo version we will have the Cron workflows working in namespace install ?

sarabala1979 pushed a commit that referenced this issue May 10, 2021
…#5846)

Signed-off-by: Nick Palumbo <npalumbo8@bloomberg.net>

Co-authored-by: Nick Palumbo <npalumbo8@bloomberg.net>
@alexec alexec mentioned this issue May 10, 2021
33 tasks
@sarabala1979 sarabala1979 mentioned this issue May 13, 2021
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants