Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): dont show cluster workflows in namespaced mode. Closes #5841 #5846

Merged
merged 1 commit into from
May 6, 2021
Merged

fix(ui): dont show cluster workflows in namespaced mode. Closes #5841 #5846

merged 1 commit into from
May 6, 2021

Conversation

Radolumbo
Copy link
Contributor

Signed-off-by: Nick Palumbo npalumbo8@bloomberg.net

Checklist:

fix: dont show cluster workflows in namespaced mode
ffbbfa2 
Signed-off-by: Nick Palumbo <npalumbo8@bloomberg.net>
@Radolumbo Radolumbo mentioned this pull request May 6, 2021
Closed
@Radolumbo
Copy link
Contributor Author

With this change, the state's namespace in the constructor now matches that in workflows-list: https://github.com/argoproj/argo-workflows/blob/master/ui/src/app/workflows/components/workflows-list/workflows-list.tsx#L114

(Same changes made to similar "list" pages in this PR: https://github.com/argoproj/argo-workflows/pull/5729/files)

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #5846 (ffbbfa2) into master (c59f59a) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5846      +/-   ##
==========================================
+ Coverage   47.34%   47.40%   +0.05%     
==========================================
  Files         247      247              
  Lines       15614    15586      -28     
==========================================
- Hits         7393     7388       -5     
+ Misses       7291     7267      -24     
- Partials      930      931       +1
Impacted Files Coverage Δ
cmd/argo/commands/get.go 57.28% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 70.66% <0.00%> (-0.28%) ⬇️
pkg/apiclient/http1-client.go 0.00% <0.00%> (ø)
pkg/apiclient/offline-client.go 0.00% <0.00%> (ø)
pkg/apiclient/panic-intermediary.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-workflow-service-client.go 0.00% <0.00%> (ø)
...piclient/argo-kube-cron-workflow-service-client.go 0.00% <0.00%> (ø)
...lient/error-translating-workflow-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
...or-translating-workflow-template-service-client.go 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59f59a...ffbbfa2. Read the comment docs.

@alexec alexec merged commit e332be5 into argoproj:master May 6, 2021
@alexec alexec added this to the v3.0 milestone May 6, 2021
@alexec
Copy link
Contributor

alexec commented May 6, 2021 •
edited
Loading

Needs back-porting to #5820

sarabala1979 pushed a commit that referenced this pull request May 10, 2021
@Radolumbo @sarabala1979
fix(ui): dont show cluster workflows in namespaced mode. Closes #5841 (…
a4c246b 
…#5846)

Signed-off-by: Nick Palumbo <npalumbo8@bloomberg.net>

Co-authored-by: Nick Palumbo <npalumbo8@bloomberg.net>
@alexec alexec mentioned this pull request May 10, 2021
Closed
33 tasks
@sarabala1979 sarabala1979 mentioned this pull request May 13, 2021
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Radolumbo @alexec