Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiveLogs is storing empty main.log files #6145

Closed
steve-marmalade opened this issue Jun 14, 2021 · 0 comments · Fixed by #6146
Closed

archiveLogs is storing empty main.log files #6145

steve-marmalade opened this issue Jun 14, 2021 · 0 comments · Fixed by #6146
Labels
type/bug
Milestone
v3.1

Comments

@steve-marmalade
Copy link
Contributor

Summary

The workflow logs that appear on the Argo Server UI are not persisted to the main.log that is stored in the artifact repository when archiveLogs: true.

Diagnostics

What Kubernetes provider are you using?

GKE on GCP, version 1.20.6-gke.1000

What version of Argo Workflows are you running?

v3.1.0-rc11

What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary

Emissary

Did this work in a previous version? I.e. is it a regression?

I am not sure (I didn't test it)

Steps to reproduce:

Relevant excerpt of workflow-controller-configmap

kubectl -n argo get configmap workflow-controller-configmap -o yaml
apiVersion: v1
data:
  artifactRepository: |
    archiveLogs: true
    gcs:
      bucket: my-argo-bucket
      key: logs
  containerRuntimeExecutor: emissary

Submit the hello-world workflow

argo submit -n argo --watch https://raw.githubusercontent.com/argoproj/argo-workflows/master/examples/hello-world.yaml

Logs show in the Argo Server UI
Screen Shot 2021-06-14 at 6 19 57 PM

main.log stored in GCS is 0 bytes :(

Screen Shot 2021-06-14 at 6 25 45 PM

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec added this to the v3.1 milestone Jun 14, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Jun 14, 2021
@alexec
fix(executor): Capture emissary main-logs. Fixes argoproj#6145
b8a5c2e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Jun 14, 2021
Merged
alexec added a commit that referenced this issue Jun 15, 2021
@alexec
fix(executor): Capture emissary main-logs. Fixes #6145 (#6146)
9f0cdbd
@alexec alexec mentioned this issue Jun 21, 2021
Closed
16 tasks
@sarabala1979 sarabala1979 mentioned this issue Jun 21, 2021
Closed
88 tasks
alexec added a commit that referenced this issue Jun 21, 2021
@alexec
fix(executor): Capture emissary main-logs. Fixes #6145 (#6146)
422f5f2 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
uturunku1 pushed a commit to newrelic-forks/argo-workflows that referenced this issue Jul 22, 2021
@alexec @uturunku1
fix(executor): Capture emissary main-logs. Fixes argoproj#6145 (argop…
069f742 
…roj#6146)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>
alexec added a commit that referenced this issue Jul 26, 2021
@uturunku1 @debellotti
@terrytangyuan @github-actions @alexec @christopheblin @marviniter @kennytrytek @CadenOf @simster7 @stefansedich @copierrj @highb @book987 @chazapis @tczhao @posquit0 @Bobgy @NikeNano @crenshaw-dev @sarabala1979 @brgoode @valorl @AntoineDao @bkh751 @aslafy-z @thiago4int
chore: upgrade to k8s v0.20.4 (#6143)
96b165e 
* Update events.md (#6119)

Trying to use the argo workflows events and I noticed that some crucial explanations are missing here. I would like to add:
- A simple WorkflowTemplate bound to the WorkflowEventBinding, to show what is triggered by the curl that send the event
- Some infos about the process that bind the event to the workflow template:
   - template creation
   - event binding apply
   - api call to trigger the workflow template creation
Plus: there is a little mistake in the selector:  metadata["x-argo"] instead of metadata["X-Argo-E2E"] I would like to correct it in order to avoid mistakes during the curl.

Hope this is appreciated! ;)

Denis

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add note on the requirements of resource templates. Fixes #5566 (#6125)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6127)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: alexec <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* add troubleshooting notes section for running-locally docs (#6132)

Co-authored-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(executor): Check whether any errors within checkResourceState() are transient. Fixes #6118. (#6134)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* build: Remove PNS_PRIVILEGED=true (#6138)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Document the extraction of data from a k8s resource (#6102)

* Document the extraction of data from a k8s resource

* remove reference to lines of a file that can be outdated

Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>

* Remove yaml snippet and only keep the link to the example

Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* build image output to docker (#6128)

Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* chore: Update stress rig and docs. Fixes #6136 (#6141)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* chore: Upgrade Alibaba OSS to use more secure ListObjectsV2() (#6142)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: Allow setting workflow input parameters in UI. Fixes #4234 (#5319)

* fix: Allow setting workflow input parameters in UI. Fixes #4234

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* fix: Allow setting workflow input parameters in UI. Fixes #4234

 - Allow workflow input parameters as well as entrypoint parameters.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): Performance improvement for Sprig. Fixes #6135 (#6140)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* update from v0.19.6 to v0.20.4 and indirect dependencies

Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* exec.GetAuthenticator takes two arguments in the k8s-client-go v0.20.4

Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* update makefile to use code-generator@v0.20.4

Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Fix release-notes.md

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Update Graviti's website link (#6148)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(ui): Fix-up local storage namespaces. Fixes #6109 (#6144)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(executor): Capture emissary main-logs. Fixes #6145 (#6146)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(ui): Fix event-flow scrolling. Fixes #6133 (#6147)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* test: Fix logging test (#6159)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(ui): Add checkbox to check all workflows in list. Fixes #6069 (#6158)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Use 'depends' instead of 'dependencies' in examples (#6166)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(server): Allow redirect_uri to be automatically resolved when using sso (#6167)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): Allow retry on transient errors when validating workflow spec. Fixes #6163 (#6178)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): dehydrate workflow before deleting offloaded node status (#6112)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6160)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: alexec <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Remove RBAC for SSO from Roadmap (Already implemented) (#6174)

It looks like RBAC for SSO is already implemented by #4198 so hopefully it can be removed from the roadmap as it is also documented? https://argoproj.github.io/argo-workflows/argo-server-sso/#sso-rbac

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6187)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: alexec <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Fix changelog order for .0 tags (#6188)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): Wrong validate order when validate DAG task's argument (#6190)

Signed-off-by: BOOK <book78987book@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix rebase conflict

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* run go mod tidy

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* refactor: Remove the need for pod annotations to be mounted as a volume (#6022)

Signed-off-by: Antony Chazapis <chazapis@ics.forth.gr>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: ContainerSets do not have 'depends' (#6199)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: Fix security issues related to file closing and paths (G307 & G304) (#6200)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add links to Python examples to description annotations (#6202)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs(executor): document k8s executor behaviour with program warnings (#6212)

* docs(executor): document k8s executor behaviour with program warnings

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

* docs(executor): fix typo

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: Fix certain sibling tasks not connected to parent (#6193)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(ui): Add copy to clipboard shortcut (#6217)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6220)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: alexec <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add KarrotPay in USERS.md (#6221)

Signed-off-by: Byungjin Park <posquit0.bj@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* run go mod tidy

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add workflow-count-resourcequota.yaml example (#6225)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: Reduce argoexec image size (#6197)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(conttroller): Always set finishedAt dote. Fixes #6135 (#6139)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat: Add support for deletion delay when using PodGC (#6168)

Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: update bug report template (#6236)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6242)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: alexec <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(executor): emissary - make argoexec executable from non-root containers. Fixes #6238 (#6247)

Signed-off-by: Yuan Gong <gongyuan94@gmail.com>

Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat: Introduce when condition to retryStrategy (#6114)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* ci: Add Go code security scanner via gosec. Fixes #6203 (#6232)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: fix end of files, new lines and remove multiple lines (#6240)

Signed-off-by: NikeNano <niklas.sven.hansson@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: add json destructuring example (#6250)


Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(executor): Tolerate docker re-creating containers. Fixes #6244 (#6252)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(executor): emissary - make /var/run/argo files readable from non-root users. Fixes #6238 (#6304)

Signed-off-by: Yuan Gong <gongyuan94@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs(controller): add missing emissary executor (#6291)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: docs and hacks improvements (#6310)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(cli): Only list needed fields. Fixes #6000 (#6298)

* fix(cli): Only list needed fields

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* ok

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Fix typo (#6311)

Signed-off-by: Byungjin Park <posquit0.bj@gmail.com>

Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* require sso redirect url to be an argo url (#6211)

Signed-off-by: Brandon Goode <brandon.goode@cox.com>

Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: code format (#6269)

- Add yaml rendering
- Add bash rendering

Co-authored-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(controller): Store artifact repository in workflow status. Fixes #6255 (#6299)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: document using ingress with TLS enabled (#6324)

Signed-off-by: valorl <11498571+valorl@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: document how to access hyphenated steps in expression templates (#6318)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(controller): Differentiate CronWorkflow submission vs invalid spec error metrics (#6309)

* feat(controller): Differentiate CronWorkflow submission vs invalid spec error metrics

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

* Address feedback

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* chore: deleted wft.yaml

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* ci: only run Snyk once a day on master

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): Not updating StoredWorkflowSpec when WFT changed during workflow running (#6342)

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(cli): v3.1 Argo Auth Token (#6344)

* fix(cli): v3.1 Argo Auth Token

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>

* update

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add Alibaba Group to USERS.md (#6353)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(crd): temp fix 34s timeout bug for k8s 1.20+ (#6350)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: updated CHANGELOG.md (#6348)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: sarabala1979 <sarabala1979@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs(users): Add WooliesX (#6358)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(cli): Overridding name/generateName when creating CronWorkflows if specified (#6308)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(controller): sortDAGTasks supports sort by field Depends (#6307)

Signed-off-by: BOOK <book78987book@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(fields): handle nexted fields when excluding (#6359)

Signed-off-by: AntoineDao <antoinedao1@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* feat(controller): Allow configurable host name label key when retrying different hosts (#6341)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* pull argo-events changes
update versions in go.mod and go.sum

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* run go mod tidy

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): allow workflow.duration to pass validator (#6376)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): fix retry on transient errors when validating workflow spec (#6370)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>

Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: examples/ci.yaml indent (#6328)

Signed-off-by: kungho.back <kungho.back@naverlabs.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* chore: import grafana dashboard (#6365)

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(gcs): throw argo not found error if key not exist (#6393)

Signed-off-by: AntoineDao <antoinedao1@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* Revert "fix: examples/ci.yaml indent (#6328)"

This reverts commit 3f72fe5.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix: Server crash when opening timeline tab for big workflows (#6369)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>

Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com>
Co-authored-by: Alex Collins <alexec@users.noreply.github.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add 4intelligence (#6400)

Signed-off-by: Thiago Gil <t.gil@4intelligence.com.br>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Add note on additional required permission for createBucketIfNotPresent for OSS driver (#6378)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): allow initial duration to be 0 instead of current_time-0 (#6389)


Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix(controller): Mark workflows wait for semaphore as pending. Fixes #6351 (#6356)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* docs: Updating upgrading.md. Closes #6314

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* not need to convert to unstructured.unstructured

I was getting this error controller_test.go: pkg/mod/k8s.io/client-go@v0.20.4/tools/cache/reflector.go:167: Failed to watch *unstructured.Unstructured: failed to list *unstructured.Unstructured: item[0]: can't assign or convert unstructured.Unstructured into v1alpha1.Workflow

Based on this comment, it seems like the conversion is not needed: kubernetes-sigs/controller-runtime#524 (comment)

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* run make pre-commit -B

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix potential file inclusion via variable lint error

there is a risk that an unintended file path will be specified. So uuse filepath.Clean() to clean up possible bad paths

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* fix format issue

Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

Co-authored-by: Denis Bellotti <denis.bellotti.android@gmail.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexec <alexec@users.noreply.github.com>
Co-authored-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”>
Co-authored-by: Christophe Blin <christophe.blin@free.fr>
Co-authored-by: meijin <859037421@qq.com>
Co-authored-by: kennytrytek <kenneth.g.trytek@gmail.com>
Co-authored-by: Caden <32856921+CadenOf@users.noreply.github.com>
Co-authored-by: Simon Behar <simbeh7@gmail.com>
Co-authored-by: Stefan Sedich <stefan.sedich@gmail.com>
Co-authored-by: Reijer Copier <copierrj@users.noreply.github.com>
Co-authored-by: Brandon High <highb@users.noreply.github.com>
Co-authored-by: BOOK <book78987book@gmail.com>
Co-authored-by: Antony Chazapis <chazapis@ics.forth.gr>
Co-authored-by: Tianchu Zhao <evantczhao@gmail.com>
Co-authored-by: Byungjin Park (Claud) <posquit0.bj@gmail.com>
Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com>
Co-authored-by: Niklas Hansson <niklas.sven.hansson@gmail.com>
Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com>
Co-authored-by: brgoode <86316314+brgoode@users.noreply.github.com>
Co-authored-by: Valér Orlovský <11498571+valorl@users.noreply.github.com>
Co-authored-by: Alex Collins <alex_collins@intuit.com>
Co-authored-by: sarabala1979 <sarabala1979@users.noreply.github.com>
Co-authored-by: Antoine Dao <antoinedao1@gmail.com>
Co-authored-by: KUNG HO BACK <bkh751@gmail.com>
Co-authored-by: Zadkiel <zadkiel.aharonian@gmail.com>
Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
Co-authored-by: Thiago Bittencourt Gil <79285506+thiago4int@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

fix(executor): Capture emissary main-logs. Fixes #6145 alexec/argo-workflows
2 participants
@alexec @steve-marmalade