feat(controller): Store artifact repository in workflow status. Fixes #6255 #6299

alexec · 2021-07-07T18:06:29Z

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6255

Changes:

Store the artifact repository in the workflow status.
We don't need to to a Get configmap for each reconciliation (up to 50% reduction in requests).
Clients can use the field to find the resource.
If the underlying configuration changes, you can still look up the value.

Example:

  status:
    artifactRepositoryRef:
      artifactRepository:
        archiveLogs: true
        s3:
          accessKeySecret:
            key: accesskey
            name: my-minio-cred
          bucket: my-bucket
          endpoint: minio:9000
          insecure: true
          secretKeySecret:
            key: secretkey
            name: my-minio-cred
      configMap: artifact-repositories
      key: default-v1
      namespace: argo
    conditions:
    - status: "True"
      type: PodRunning
    finishedAt: null
    offloadNodeStatusVersion: fnv:1056331912
    phase: Running
    progress: 0/1
    startedAt: "2021-07-07T22:48:59Z"

…6255 Signed-off-by: Alex Collins <alex_collins@intuit.com>

codecov · 2021-07-07T18:12:25Z

Codecov Report

Merging #6299 (140557a) into master (088c48b) will increase coverage by 0.06%.
The diff coverage is 93.50%.

❗ Current head 140557a differs from pull request most recent head 882ac79. Consider uploading reports for the commit 882ac79 to get more accurate results

@@            Coverage Diff             @@
##           master    #6299      +/-   ##
==========================================
+ Coverage   49.14%   49.20%   +0.06%     
==========================================
  Files         250      251       +1     
  Lines       17924    17939      +15     
==========================================
+ Hits         8808     8827      +19     
+ Misses       8150     8146       -4     
  Partials      966      966

Impacted Files	Coverage Δ
config/config.go	`31.57% <ø> (-37.74%)`	⬇️
pkg/apis/workflow/v1alpha1/workflow_types.go	`49.82% <ø> (ø)`
workflow/common/common.go	`80.00% <ø> (ø)`
workflow/controller/operator.go	`72.48% <ø> (+0.24%)`	⬆️
...kflow/artifactrepositories/artifactrepositories.go	`89.65% <85.18%> (+1.28%)`	⬆️
...pis/workflow/v1alpha1/artifact_repository_types.go	`98.00% <98.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088c48b...882ac79. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>

terrytangyuan · 2021-07-11T03:58:33Z

pkg/apis/workflow/v1alpha1/generated.proto

@@ -138,6 +159,9 @@ message ArtifactRepositoryRefStatus {

  // If this ref represents the default artifact repository, rather than a config map.
  optional bool default = 3;
+
+  // The repository the workflow will use. This maybe empty before v3.1.


Should this be v3.2 since v3.1 won't have this feature?

I plan to backport.

Bobgy · 2021-07-12T03:59:20Z

Thank you! This is exactly what we wanted in #6255.
Several side effects that come with the change seems ideal for argo itself too (perf improvement, stable handling of artifact repository config change).

alexec · 2021-07-12T20:31:14Z

@jessesuen I need your review on the proto changes for this v3.1 fix. It is to enable Kubeflow Pipelines to use v3.1.

jessesuen

LGTM

…rgoproj#6255 (argoproj#6299) Signed-off-by: Alex Collins <alex_collins@intuit.com>

…rgoproj#6255 (argoproj#6299) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com>

* Update events.md (#6119) Trying to use the argo workflows events and I noticed that some crucial explanations are missing here. I would like to add: - A simple WorkflowTemplate bound to the WorkflowEventBinding, to show what is triggered by the curl that send the event - Some infos about the process that bind the event to the workflow template: - template creation - event binding apply - api call to trigger the workflow template creation Plus: there is a little mistake in the selector: metadata["x-argo"] instead of metadata["X-Argo-E2E"] I would like to correct it in order to avoid mistakes during the curl. Hope this is appreciated! ;) Denis Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add note on the requirements of resource templates. Fixes #5566 (#6125) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6127) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * add troubleshooting notes section for running-locally docs (#6132) Co-authored-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(executor): Check whether any errors within checkResourceState() are transient. Fixes #6118. (#6134) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * build: Remove PNS_PRIVILEGED=true (#6138) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Document the extraction of data from a k8s resource (#6102) * Document the extraction of data from a k8s resource * remove reference to lines of a file that can be outdated Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> * Remove yaml snippet and only keep the link to the example Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * build image output to docker (#6128) Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * chore: Update stress rig and docs. Fixes #6136 (#6141) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * chore: Upgrade Alibaba OSS to use more secure ListObjectsV2() (#6142) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: Allow setting workflow input parameters in UI. Fixes #4234 (#5319) * fix: Allow setting workflow input parameters in UI. Fixes #4234 Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com> * fix: Allow setting workflow input parameters in UI. Fixes #4234 - Allow workflow input parameters as well as entrypoint parameters. Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): Performance improvement for Sprig. Fixes #6135 (#6140) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * update from v0.19.6 to v0.20.4 and indirect dependencies Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * exec.GetAuthenticator takes two arguments in the k8s-client-go v0.20.4 Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * update makefile to use code-generator@v0.20.4 Signed-off-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Fix release-notes.md Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Update Graviti's website link (#6148) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(ui): Fix-up local storage namespaces. Fixes #6109 (#6144) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(executor): Capture emissary main-logs. Fixes #6145 (#6146) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(ui): Fix event-flow scrolling. Fixes #6133 (#6147) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * test: Fix logging test (#6159) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(ui): Add checkbox to check all workflows in list. Fixes #6069 (#6158) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Use 'depends' instead of 'dependencies' in examples (#6166) Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(server): Allow redirect_uri to be automatically resolved when using sso (#6167) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): Allow retry on transient errors when validating workflow spec. Fixes #6163 (#6178) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): dehydrate workflow before deleting offloaded node status (#6112) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6160) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Remove RBAC for SSO from Roadmap (Already implemented) (#6174) It looks like RBAC for SSO is already implemented by #4198 so hopefully it can be removed from the roadmap as it is also documented? https://argoproj.github.io/argo-workflows/argo-server-sso/#sso-rbac Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6187) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Fix changelog order for .0 tags (#6188) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): Wrong validate order when validate DAG task's argument (#6190) Signed-off-by: BOOK <book78987book@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix rebase conflict Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * run go mod tidy Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * refactor: Remove the need for pod annotations to be mounted as a volume (#6022) Signed-off-by: Antony Chazapis <chazapis@ics.forth.gr> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: ContainerSets do not have 'depends' (#6199) Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: Fix security issues related to file closing and paths (G307 & G304) (#6200) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add links to Python examples to description annotations (#6202) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs(executor): document k8s executor behaviour with program warnings (#6212) * docs(executor): document k8s executor behaviour with program warnings Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> * docs(executor): fix typo Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: Fix certain sibling tasks not connected to parent (#6193) Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(ui): Add copy to clipboard shortcut (#6217) Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6220) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add KarrotPay in USERS.md (#6221) Signed-off-by: Byungjin Park <posquit0.bj@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * run go mod tidy Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add workflow-count-resourcequota.yaml example (#6225) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: Reduce argoexec image size (#6197) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(conttroller): Always set finishedAt dote. Fixes #6135 (#6139) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat: Add support for deletion delay when using PodGC (#6168) Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: update bug report template (#6236) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6242) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(executor): emissary - make argoexec executable from non-root containers. Fixes #6238 (#6247) Signed-off-by: Yuan Gong <gongyuan94@gmail.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat: Introduce when condition to retryStrategy (#6114) Signed-off-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * ci: Add Go code security scanner via gosec. Fixes #6203 (#6232) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: fix end of files, new lines and remove multiple lines (#6240) Signed-off-by: NikeNano <niklas.sven.hansson@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: add json destructuring example (#6250) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(executor): Tolerate docker re-creating containers. Fixes #6244 (#6252) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(executor): emissary - make /var/run/argo files readable from non-root users. Fixes #6238 (#6304) Signed-off-by: Yuan Gong <gongyuan94@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs(controller): add missing emissary executor (#6291) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: docs and hacks improvements (#6310) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(cli): Only list needed fields. Fixes #6000 (#6298) * fix(cli): Only list needed fields Signed-off-by: Alex Collins <alex_collins@intuit.com> * ok Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Fix typo (#6311) Signed-off-by: Byungjin Park <posquit0.bj@gmail.com> Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * require sso redirect url to be an argo url (#6211) Signed-off-by: Brandon Goode <brandon.goode@cox.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: code format (#6269) - Add yaml rendering - Add bash rendering Co-authored-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(controller): Store artifact repository in workflow status. Fixes #6255 (#6299) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: document using ingress with TLS enabled (#6324) Signed-off-by: valorl <11498571+valorl@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: document how to access hyphenated steps in expression templates (#6318) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(controller): Differentiate CronWorkflow submission vs invalid spec error metrics (#6309) * feat(controller): Differentiate CronWorkflow submission vs invalid spec error metrics Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Address feedback Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * chore: deleted wft.yaml Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * ci: only run Snyk once a day on master Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): Not updating StoredWorkflowSpec when WFT changed during workflow running (#6342) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(cli): v3.1 Argo Auth Token (#6344) * fix(cli): v3.1 Argo Auth Token Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add Alibaba Group to USERS.md (#6353) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(crd): temp fix 34s timeout bug for k8s 1.20+ (#6350) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: updated CHANGELOG.md (#6348) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: sarabala1979 <sarabala1979@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs(users): Add WooliesX (#6358) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(cli): Overridding name/generateName when creating CronWorkflows if specified (#6308) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(controller): sortDAGTasks supports sort by field Depends (#6307) Signed-off-by: BOOK <book78987book@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(fields): handle nexted fields when excluding (#6359) Signed-off-by: AntoineDao <antoinedao1@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * feat(controller): Allow configurable host name label key when retrying different hosts (#6341) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * pull argo-events changes update versions in go.mod and go.sum Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * run go mod tidy Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): allow workflow.duration to pass validator (#6376) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): fix retry on transient errors when validating workflow spec (#6370) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: examples/ci.yaml indent (#6328) Signed-off-by: kungho.back <kungho.back@naverlabs.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * chore: import grafana dashboard (#6365) Signed-off-by: GitHub <noreply@github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(gcs): throw argo not found error if key not exist (#6393) Signed-off-by: AntoineDao <antoinedao1@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * Revert "fix: examples/ci.yaml indent (#6328)" This reverts commit 3f72fe5. Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix: Server crash when opening timeline tab for big workflows (#6369) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com> Co-authored-by: Alex Collins <alexec@users.noreply.github.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add 4intelligence (#6400) Signed-off-by: Thiago Gil <t.gil@4intelligence.com.br> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Add note on additional required permission for createBucketIfNotPresent for OSS driver (#6378) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): allow initial duration to be 0 instead of current_time-0 (#6389) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix(controller): Mark workflows wait for semaphore as pending. Fixes #6351 (#6356) Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * docs: Updating upgrading.md. Closes #6314 Signed-off-by: Alex Collins <alex_collins@intuit.com> Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * not need to convert to unstructured.unstructured I was getting this error controller_test.go: pkg/mod/k8s.io/client-go@v0.20.4/tools/cache/reflector.go:167: Failed to watch *unstructured.Unstructured: failed to list *unstructured.Unstructured: item[0]: can't assign or convert unstructured.Unstructured into v1alpha1.Workflow Based on this comment, it seems like the conversion is not needed: kubernetes-sigs/controller-runtime#524 (comment) Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * run make pre-commit -B Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix potential file inclusion via variable lint error there is a risk that an unintended file path will be specified. So uuse filepath.Clean() to clean up possible bad paths Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> * fix format issue Signed-off-by: uturunku1 <luces.huayhuaca@gmail.com> Co-authored-by: Denis Bellotti <denis.bellotti.android@gmail.com> Co-authored-by: Yuan Tang <terrytangyuan@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: alexec <alexec@users.noreply.github.com> Co-authored-by: uturunku1 <“21225410+uturunku1@users.noreply.github.com”> Co-authored-by: Christophe Blin <christophe.blin@free.fr> Co-authored-by: meijin <859037421@qq.com> Co-authored-by: kennytrytek <kenneth.g.trytek@gmail.com> Co-authored-by: Caden <32856921+CadenOf@users.noreply.github.com> Co-authored-by: Simon Behar <simbeh7@gmail.com> Co-authored-by: Stefan Sedich <stefan.sedich@gmail.com> Co-authored-by: Reijer Copier <copierrj@users.noreply.github.com> Co-authored-by: Brandon High <highb@users.noreply.github.com> Co-authored-by: BOOK <book78987book@gmail.com> Co-authored-by: Antony Chazapis <chazapis@ics.forth.gr> Co-authored-by: Tianchu Zhao <evantczhao@gmail.com> Co-authored-by: Byungjin Park (Claud) <posquit0.bj@gmail.com> Co-authored-by: Yuan (Bob) Gong <4957653+Bobgy@users.noreply.github.com> Co-authored-by: Niklas Hansson <niklas.sven.hansson@gmail.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com> Co-authored-by: brgoode <86316314+brgoode@users.noreply.github.com> Co-authored-by: Valér Orlovský <11498571+valorl@users.noreply.github.com> Co-authored-by: Alex Collins <alex_collins@intuit.com> Co-authored-by: sarabala1979 <sarabala1979@users.noreply.github.com> Co-authored-by: Antoine Dao <antoinedao1@gmail.com> Co-authored-by: KUNG HO BACK <bkh751@gmail.com> Co-authored-by: Zadkiel <zadkiel.aharonian@gmail.com> Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Co-authored-by: Thiago Bittencourt Gil <79285506+thiago4int@users.noreply.github.com>

feat(controller): Store artifact repostiory in workflow status. Fixes #…

66582b1

…6255 Signed-off-by: Alex Collins <alex_collins@intuit.com>

ok

d3af2be

Signed-off-by: Alex Collins <alex_collins@intuit.com>

alexec linked an issue Jul 7, 2021 that may be closed by this pull request

Successfully finished pods show stuck in pending phase indefinitely in GKE + Kubernetes v1.20 #6256

Closed

alexec and others added 2 commits July 7, 2021 16:03

ok

edf36e6

Signed-off-by: Alex Collins <alex_collins@intuit.com>

Merge branch 'master' into dev-6255

d348ca8

alexec marked this pull request as ready for review July 11, 2021 03:40

alexec requested a review from jessesuen as a code owner July 11, 2021 03:40

terrytangyuan reviewed Jul 11, 2021

View reviewed changes

alexec assigned jessesuen Jul 12, 2021

jessesuen approved these changes Jul 12, 2021

View reviewed changes

Merge branch 'master' into dev-6255

882ac79

alexec enabled auto-merge (squash) July 12, 2021 21:07

alexec removed a link to an issue Jul 12, 2021

Successfully finished pods show stuck in pending phase indefinitely in GKE + Kubernetes v1.20 #6256

Closed

alexec added this to the v3.1 milestone Jul 12, 2021

alexec merged commit 85c9279 into master Jul 12, 2021

alexec deleted the dev-6255 branch July 12, 2021 21:24

Bobgy pushed a commit to Bobgy/argo-workflows that referenced this pull request Jul 13, 2021

feat(controller): Store artifact repository in workflow status. Fixes a…

f8b688d

…rgoproj#6255 (argoproj#6299) Signed-off-by: Alex Collins <alex_collins@intuit.com>

sarabala1979 mentioned this pull request Jul 13, 2021

v3.1.2 cherry-pick #6330

Closed

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(controller): Store artifact repository in workflow status. Fixes #6255 #6299

feat(controller): Store artifact repository in workflow status. Fixes #6255 #6299

alexec commented Jul 7, 2021 •

edited

Loading

codecov bot commented Jul 7, 2021 •

edited

Loading

terrytangyuan Jul 11, 2021

alexec Jul 11, 2021

Bobgy commented Jul 12, 2021

alexec commented Jul 12, 2021

jessesuen left a comment

feat(controller): Store artifact repository in workflow status. Fixes #6255 #6299

feat(controller): Store artifact repository in workflow status. Fixes #6255 #6299

Conversation

alexec commented Jul 7, 2021 • edited Loading

codecov bot commented Jul 7, 2021 • edited Loading

Codecov Report

terrytangyuan Jul 11, 2021

Choose a reason for hiding this comment

alexec Jul 11, 2021

Choose a reason for hiding this comment

Bobgy commented Jul 12, 2021

alexec commented Jul 12, 2021

jessesuen left a comment

Choose a reason for hiding this comment

alexec commented Jul 7, 2021 •

edited

Loading

codecov bot commented Jul 7, 2021 •

edited

Loading