Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erratum in docs #8342

Closed
felix-dpg opened this issue Apr 8, 2022 · 2 comments · Fixed by #8359
Closed

Erratum in docs #8342

felix-dpg opened this issue Apr 8, 2022 · 2 comments · Fixed by #8359
Labels
area/docs Incorrect, missing, or mistakes in docs good first issue Good for newcomers type/feature Feature request

Comments

@felix-dpg
Copy link

Summary

What change needs making?

In the docs, recursion section has an erratum in the Workflow template

      - name: tails                     # keep flipping coins if "tails"
        template: coinflip
        when: "{{steps.flip-coin.outputs.result}} == tails"

Template must be flip-coin

Thanks in advance and BTW, very nice work with argo workflow!!!
@felix-dpg felix-dpg added the type/feature Feature request label Apr 8, 2022
@alexec
Copy link
Contributor

alexec commented Apr 8, 2022

Could you like to submit a PR to fix?

@alexec alexec added good first issue Good for newcomers area/docs Incorrect, missing, or mistakes in docs labels Apr 8, 2022
@msidana
Copy link
Contributor

msidana commented Apr 11, 2022

Can I work on this ?

msidana added a commit to msidana/argo-workflows that referenced this issue Apr 11, 2022
@msidana
fix: Erratum in docs. Fixes argoproj#8342
63655a6 
Updated the template name from coinflip to flip-coin according to intended behaviour specified.
msidana added a commit to msidana/argo-workflows that referenced this issue Apr 11, 2022
@msidana
fix: Erratum in docs. Fixes argoproj#8342
324078d 
Signed-off-by: Manik Sidana <maniksidana019@gmail.com>
@msidana msidana mentioned this issue Apr 11, 2022
Merged
terrytangyuan pushed a commit that referenced this issue Apr 11, 2022
@msidana
fix: Erratum in docs. Fixes #8342 (#8359)
e9de085
@sarabala1979 sarabala1979 mentioned this issue Apr 14, 2022
Closed
85 tasks
This was referenced Jun 20, 2022
Closed
Closed
@sarabala1979 sarabala1979 mentioned this issue Jul 30, 2022
Closed
51 tasks
@sarabala1979 sarabala1979 mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs Incorrect, missing, or mistakes in docs good first issue Good for newcomers type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Erratum in docs. Fixes #8342 msidana/argo-workflows
3 participants
@alexec @msidana @felix-dpg