Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick v3.3.2 #8401

Closed
38 of 85 tasks
sarabala1979 opened this issue Apr 14, 2022 · 13 comments
Closed
38 of 85 tasks

Cherry pick v3.3.2 #8401

sarabala1979 opened this issue Apr 14, 2022 · 13 comments
Labels
type/feature Feature request

Comments

@sarabala1979
Copy link
Member

sarabala1979 commented Apr 14, 2022 •
edited by alexec
Loading

@sarabala1979 sarabala1979 added the type/feature Feature request label Apr 14, 2022
@sarabala1979
Copy link
Member Author

@alexec Can you select your issues which should go into v3.3?

@alexec
Copy link
Contributor

alexec commented Apr 14, 2022

I think some of these fixes are already in v3.3. I've checked as requested.

@kulinskyvs
Copy link

Hello,

Is there any estimated date for the "3.3.2" release?

Thank you!

@tooptoop4
Copy link
Contributor

please include #8397

@alexec alexec mentioned this issue Apr 18, 2022
Closed
@alexec
Copy link
Contributor

alexec commented Apr 18, 2022

I've cherry-picked a0148c1 to fix #8257.

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022 

=== RUN   TestRunAsNonRootSuite
[321](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:321)
time="2022-04-19T12:22:37Z" level=info msg="config map" name=workflow-controller-configmap
[322](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:322)
=== RUN   TestRunAsNonRootSuite/TestRunAsNonRootWithOutputParams
[323](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:323)
Submitting workflow  runasnonroot-output-params-
[324](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:324)
Waiting 1m0s for workflow metadata.name=runasnonroot-output-params-5dqpz
[325](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:325)
 ? runasnonroot-output-params-5dqpz Workflow 0s      
[326](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:326)

[327](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:327)
 ● runasnonroot-output-params-5dqpz   Workflow 0s      
[328](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:328)
 └ ◷ runasnonroot-output-params-5dqpz Pod      0s      
[329](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:329)

[330](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:330)
 ● runasnonroot-output-params-5dqpz   Workflow 0s      
[331](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:331)
 └ ● runasnonroot-output-params-5dqpz Pod      0s      
[332](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:332)

[333](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:333)
 ● runasnonroot-output-params-5dqpz   Workflow 0s      
[334](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:334)
 └ ● runasnonroot-output-params-5dqpz Pod      0s      
[335](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:335)

[336](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:336)
 ⚠ runasnonroot-output-params-5dqpz   Workflow 4s      Error (exit code 1): failed to chroot to main filesystem: operation not permitted
[337](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:337)
 └ ⚠ runasnonroot-output-params-5dqpz Pod      2s      Error (exit code 1): failed to chroot to main filesystem: operation not permitted
[338](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:338)

[339](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:339)
    run_as_not_root_test.go:33: condition never and cannot be met because the workflow is done
[340](https://github.com/argoproj/argo-workflows/runs/6077659329?check_suite_focus=true#step:14:340)
=== FAIL: RunAsNonRootSuite/TestRunAsNonRootWithOutputParams

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022

3d60693 - PASS

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022

#3500

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022

https://github.com/argoproj/argo-workflows/compare/release-3.3

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022 •
edited
Loading

Is the version of the executor correct?

&Version{Version:untagged,BuildDate:2022-04-18T23:06:22Z,GitCommit:88054f3308c508b7761401a52c384699217b2427,GitTag:untagged,GitTreeState:clean,GoVersion:go1.17.9,Compiler:gc,Platform:linux/amd64,}"

Should be 88054f3, so correct.

@alexec
Copy link
Contributor

alexec commented Apr 19, 2022

https://github.com/argoproj/argo-workflows/actions/runs/2190437810

@alexec alexec closed this as completed Apr 25, 2022
@whybeyoung
Copy link
Contributor

whybeyoung commented Apr 27, 2022 •
edited
Loading

why the 8176 not be released?

@whybeyoung
Copy link
Contributor

@sarabala1979 And actually #8194 is not released ,and it was checked ....

@jfb74 jfb74 mentioned this issue Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kulinskyvs @alexec @whybeyoung @tooptoop4 @sarabala1979