fix: Support --parameters-file where ARGO_SERVER specified. Fixes #8160
#8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oproj#8160 Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
changed the title
--parameter-file where ARGO_SERVER specified. Fixes #8160--parameters-file where ARGO_SERVER specified. Fixes #8160
Signed-off-by: Alex Collins <alex_collins@intuit.com>
…oproj#8160 Signed-off-by: Alex Collins <alex_collins@intuit.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
Mar 23, 2022
…rgoproj#8160 (argoproj#8213) Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #8160
This feature was broken because the argo server was trying to load the file from its own file-system. This moves the load client side.
Luckily, the argo server did not have any files on it's file system, so (a) you could not do
--parameters-file=/etcpasswdand (b) it would have never worked.