Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed deprecated k8sapi executor. Fixes #7802 #8205

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

rohankmr414
Copy link
Member

Signed-off-by: Rohan Kumar rohankmr414@gmail.com

Fixes #7802

Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
@rohankmr414
Copy link
Member Author

didn't remove the workflow/executor/k8sapi package as pns executor depends on it

type PNSExecutor struct {
*k8sapi.K8sAPIExecutor
podName string
namespace string
// mu for `containerNameToPID``
mu sync.RWMutex
// mu for `pidFileHandles``
pmu sync.RWMutex
containerNameToPID map[string]int
// pidFileHandles holds file handles to all root containers
pidFileHandles map[int]*os.File
// thisPID is the pid of this process
thisPID int
// rootFS holds a file descriptor to the root filesystem, allowing the executor to exit out of a chroot
rootFS *os.File
}

@alexec alexec merged commit 8a1fbb8 into argoproj:master Mar 22, 2022
@rohankmr414 rohankmr414 deleted the k8sapi branch March 22, 2022 15:21
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request Mar 23, 2022
…j#8205)

Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
@sarabala1979 sarabala1979 mentioned this pull request May 25, 2022
14 tasks
This was referenced Jun 20, 2022
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
sarabala1979 pushed a commit that referenced this pull request Aug 8, 2022
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove k8sapi executor
2 participants