fix: Flakey test about lifecycle hooks. Fixes #10897 #10898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
|
above test failed but another reason. |
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
|
above test failed but another reason. +1 |
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
|
above test failed but another reason. +2 |
Signed-off-by: GeunSam2 <rootiron96@gmail.com>
|
Five ci(for hooks) were not failed continuously. |
terrytangyuan
approved these changes
Apr 13, 2023
44 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
May 25, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…#10898) Signed-off-by: GeunSam2 <rootiron96@gmail.com>
agilgur5
changed the title
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…#10898) Signed-off-by: GeunSam2 <rootiron96@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10897
also relate with #10807 (comment)
This issue unreproducible at local but pretty consistent on ci enviroment.
I guess if task end to early, running hook can't meet conditions so never trigger. (on slow environment)
This issue can prevent by sleeping 1 second.
You guys think this is bug that need to make new ticket?