Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flakey test about lifecycle hooks. Fixes #10897 #10898

Merged
merged 10 commits into from
Apr 13, 2023
Merged

fix: Flakey test about lifecycle hooks. Fixes #10897 #10898

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
018d1b6
fix: fix-test-error
GeunSam2 Apr 10, 2023
1cf9834
fix: fix-test-error2
GeunSam2 Apr 10, 2023
b40e698
fix: add sleep for hooks test.#10897
GeunSam2 Apr 13, 2023
5c07e11
test: add one line for trigger ci test.
GeunSam2 Apr 13, 2023
a646abc
test: reduce sleep time 5 to 3.
GeunSam2 Apr 13, 2023
b089dc8
test: reduce sleep time 3 to 1.
GeunSam2 Apr 13, 2023
02268c9
test: add one line for trigger ci test.
GeunSam2 Apr 13, 2023
34e1060
test: remove one line for trigger ci test.
GeunSam2 Apr 13, 2023
04aaa5e
test: add one line for trigger ci test.
GeunSam2 Apr 13, 2023
34fb417
test: remove one line for trigger ci test.
GeunSam2 Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions test/e2e/hooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeSucceeded).
Expand Down Expand Up @@ -88,12 +89,14 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay", "sleep 5", "exit 1"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay; exit 1"]

- name: hook
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeFailed).
Expand Down Expand Up @@ -143,7 +146,8 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeSucceeded).
Expand Down Expand Up @@ -192,11 +196,13 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay", "sleep 5", "exit 1"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay; exit 1"]
- name: hook
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeFailed).
Expand Down Expand Up @@ -248,7 +254,8 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeSucceeded).
Expand Down Expand Up @@ -298,11 +305,13 @@ spec:
- name: argosay
container:
image: argoproj/argosay:v2
command: ["/argosay", "sleep 5", "exit 1"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay; exit 1"]
- name: hook
container:
image: argoproj/argosay:v2
command: ["/argosay"]
command: ["/bin/sh", "-c"]
args: ["/bin/sleep 1; /argosay"]
`).When().
SubmitWorkflow().
WaitForWorkflow(fixtures.ToBeFailed).
Expand Down