feat: add pendingTimeout for non-deadline timeout Fixes #10341 #12762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Lawler <dlawler@gmail.com>
Signed-off-by: Dennis Lawler <dlawler@gmail.com>
Signed-off-by: Dennis Lawler <dlawler@gmail.com>
Signed-off-by: Dennis Lawler <dlawler@gmail.com>
Signed-off-by: Dennis Lawler <dlawler@gmail.com>
Joibel
reviewed
Jul 2, 2024
| if templateDeadline != nil { | ||
| if !pendingOnly && (pod.Spec.ActiveDeadlineSeconds == nil || time.Since(*templateDeadline).Seconds() < float64(*pod.Spec.ActiveDeadlineSeconds)) { | ||
| newActiveDeadlineSeconds := int64(time.Until(*templateDeadline).Seconds()) | ||
| if newActiveDeadlineSeconds <= 1 { |
There was a problem hiding this comment.
It seems slightly odd that we cut off with 1 second remaining on the deadline - any reason this is not zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10341
Motivation
Current Template timeout parameter can handle nodes spending too long in pending phase, but if the node happens to progress to running this timeout parameter transfers to activeDeadlineSeconds, leaving no way to set a timeout that covers just the pending phase.
Modifications
I added a new
pendingTimeoutfield to Template that should only apply while a node is inpendingphase. Existing logic for timeout was re-used and expanded, and requeueAfter was added to help ensure more timely deadline enforcement.Verification
Added TestCheckTemplateTimeouts to operator_test, performed manual verifications with a workflow with sleeping + unschedulable pods with combinations of pendingTimeout and timeout