fix: Mark Pending pod nodes as Failed when shutting down. Fixes #13210
#13214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj#13210 Signed-off-by: oninowang <oninowang@tencent.com>
Signed-off-by: oninowang <oninowang@tencent.com>
agilgur5
changed the title
Pending nodes of pod type Failed when shutting down. Fixes #13210Pending pod nodes as Failed when shutting down. Fixes #13210
|
Ah we've discussed this before, in #11493 (comment) and the feature request for a "Canceled" status that would more accurately describe this: #11849. Nice analysis that the current behavior affects retries @jswxstw! |
agilgur5
approved these changes
Jun 23, 2024
agilgur5
pushed a commit
that referenced
this pull request
Jul 6, 2024
agilgur5
pushed a commit
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13210
Motivation
see #13210 (comment)
Modifications
Mark
Pendingnodes of pod typeFailedwhen shutting down.Verification
updated UT