Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Fix pod spec jumbling. Fixes #5897 #5899

Merged
merged 2 commits into from
May 13, 2021
Merged

fix(controller): Fix pod spec jumbling. Fixes #5897 #5899

merged 2 commits into from
May 13, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 13, 2021 •
edited
Loading

No description provided.

@alexec
fix(controller): Fix pod spec jumbling. Fixes argoproj#5895
884de38 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue May 13, 2021 that may be closed by this pull request
v3: podSpecPatch can result in failed workflow #5897
Closed
@alexec alexec added this to the v3.0 milestone May 13, 2021
@alexec
ok
ba3518a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #5899 (ba3518a) into master (3fff791) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5899      +/-   ##
==========================================
- Coverage   47.43%   47.40%   -0.03%     
==========================================
  Files         247      247              
  Lines       15595    15596       +1     
==========================================
- Hits         7397     7393       -4     
- Misses       7268     7272       +4     
- Partials      930      931       +1
Impacted Files Coverage Δ
workflow/controller/workflowpod.go 72.49% <100.00%> (+0.04%) ⬆️
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
cmd/argo/commands/get.go 57.92% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 70.48% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fff791...ba3518a. Read the comment docs.

@alexec alexec marked this pull request as ready for review May 13, 2021 15:17
@alexec
Copy link
Contributor Author

alexec commented May 13, 2021

@sarabala1979 please approve. Needs to back port to v3.0.4

@alexec alexec changed the title fix(controller): Fix pod spec jumbling. Fixes #5895 fix(controller): Fix pod spec jumbling. Fixes #5897 May 13, 2021
@alexec alexec merged commit e71d33c into argoproj:master May 13, 2021
@alexec alexec deleted the pod-spec-patch branch May 13, 2021 15:42
@sarabala1979 sarabala1979 mentioned this pull request May 13, 2021
Closed
35 tasks
sarabala1979 pushed a commit that referenced this pull request May 14, 2021
@alexec @sarabala1979
fix(controller): Fix pod spec jumbling. Fixes #5897 (#5899)
d3ed51e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this pull request May 21, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

v3: podSpecPatch can result in failed workflow
2 participants
@alexec @sarabala1979