-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove LIST_LIMIT in workflow informer #9700
Conversation
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
c47703a
to
3ba74f8
Compare
For posterity: the controller framework already uses a default limit of 500. And so previous change was unnecessarily reducing this. EDIT: actually logs show it properly being used. I confused cronworkflow logs with workflow logs
|
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: juchao <juchao@coscene.io>
Reverts part of the changes in #9691 since we need to verify correctness on pagination.