fix: Remove LIST_LIMIT in workflow informer (argoproj#9700)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: juchao <juchao@coscene.io>
juchaosong · Nov 3, 2022 · eb32158 · eb32158
1 parent d184742
commit eb32158
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/docs/environment-variables.md b/docs/environment-variables.md
@@ -40,7 +40,6 @@ most users. Environment variables may be removed at any time.
 | `LEADER_ELECTION_LEASE_DURATION`       | `time.Duration`     | `15s`                                                                                       | The duration that non-leader candidates will wait to force acquire leadership.                                                                                                                                                                                           |
 | `LEADER_ELECTION_RENEW_DEADLINE`       | `time.Duration`     | `10s`                                                                                       | The duration that the acting master will retry refreshing leadership before giving up.                                                                                                                                                                                   |
 | `LEADER_ELECTION_RETRY_PERIOD`         | `time.Duration`     | `5s`                                                                                        | The duration that the leader election clients should wait between tries of actions.                                                                                                                                                                                      |
-| `LIST_LIMIT`                           | `int`               | `200`                                                                                       | The maximum number of responses to return for a list call on workflows for workflow informer.                                                                                                                                                                            |
 | `MAX_OPERATION_TIME`                   | `time.Duration`     | `30s`                                                                                       | The maximum time a workflow operation is allowed to run for before re-queuing the workflow onto the work queue.                                                                                                                                                          |
 | `OFFLOAD_NODE_STATUS_TTL`              | `time.Duration`     | `5m`                                                                                        | The TTL to delete the offloaded node status. Currently only used for testing.                                                                                                                                                                                            |
 | `POD_NAMES`                            | `string`            | `v2`                                                                                        | Whether to have pod names contain the template name (v2) or be the node id (v1) - should be set the same for Argo Server.                                                                                                                                                |

diff --git a/workflow/controller/controller.go b/workflow/controller/controller.go
@@ -803,7 +803,6 @@ func (wfc *WorkflowController) tweakListOptions(options *metav1.ListOptions) {
 	labelSelector := labels.NewSelector().
 		Add(util.InstanceIDRequirement(wfc.Config.InstanceID))
 	options.LabelSelector = labelSelector.String()
-	options.Limit = int64(env.LookupEnvIntOr("LIST_LIMIT", 200))
 }
 
 func getWfPriority(obj interface{}) (int32, time.Time) {