Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra fix. #235

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Hydra fix. #235

merged 3 commits into from
Jun 7, 2021

Conversation

benjaminrwilson
Copy link
Contributor

There is currently an issue when initializing hydra from another library when using argoverse. This will mitigate this issue until another solution can be determined (if needed).

@benjaminrwilson
Copy link
Contributor Author

@johnwlambert -- whenever you get a chance.

Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment.

argoverse/sensor_dataset_config.py Show resolved Hide resolved
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnwlambert
Copy link
Contributor

Do you mind pinging Omry in the thread here about the issue you saw, facebookresearch/hydra#1628?

@benjaminrwilson benjaminrwilson merged commit a936ff8 into argoverse:master Jun 7, 2021
@benjaminrwilson benjaminrwilson deleted the hydra-fix branch June 7, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants