Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented injector step #34

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Implemented injector step #34

merged 4 commits into from
Apr 9, 2019

Conversation

ElChache
Copy link
Collaborator

@ElChache ElChache commented Apr 5, 2019

It must contain a :inject keyword with a function as a value.
The function must return either a step or a collection of them

ElChache added 3 commits April 9, 2019 09:40
It must contain a :inject keyword with a function as a value.
The function must return either a step or a collection of them
Also fixed some small things on README: names are optional now, and one small syntax error
README.md Outdated Show resolved Hide resolved
(let [res (cond
processor (processor ctx)
tap (tap ctx)
inject (inject ctx))
assoc-result-fn (cond
(not (nil? tap)) (partial assoc-tap-result fonda-ctx)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These (not (nil? thing)) can be safely translated to thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

Copy link
Owner

@arichiardi arichiardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@arichiardi arichiardi merged commit 7d68e07 into master Apr 9, 2019
@arichiardi arichiardi deleted the inject-steps branch April 9, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants