[Fix #24] Make short-circuiting for anomalies optional #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
optional-anomaly
branch
from
2655475 to
e5f199e
Compare
A user of the library might not need to use anomalies but just need to throw on exceptions. This patch makes the anomaly machinery optional. When the :anomaly? config key is truthy we now enable the functionality. The patch is *Breaking* as it also changes the signature of fonda.core/execute for a more node-friendly callback style - on-exception first then on-success.
arichiardi
force-pushed
the
optional-anomaly
branch
from
e5f199e to
8208232
Compare
ElChache
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of the library might not need to use anomalies but just need to throw on
exceptions. This patch makes the anomaly machinery optional.
When the :anomaly? config key is truthy we now enable the functionality.
The patch is Breaking as it also changes the signature of
fonda.core/executefor a more node-friendly callback style -on-exceptionfirst then
on-success.