-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/cv containers delete configlets #168
Merged
titom73
merged 7 commits into
releases/v1.1.x
from
features/cv-containers-delete-configlets
Apr 22, 2020
Merged
Features/cv containers delete configlets #168
titom73
merged 7 commits into
releases/v1.1.x
from
features/cv-containers-delete-configlets
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/rebase |
titom73
added
module: cv_container
Issue related to cv_container module
state: accepted
Issue is part of the development roadmap
status: in-progress
Currently under investigation or implementation
type: enhancement
New feature or request
labels
Mar 23, 2020
cv_container now support option to remove configlet(s) from container by using a new optional keyword. Meantime, this keyword allows user to also filter configlets to attach to container Module Behavior: ---------------- - Add new optional input: configlet_filter (list) - Addition process: - if configlet from intended match filter: configlet is attached - if configlet from intended does not match filter: configlet is ignored - configlet_filter = ['none'] filtering is ignored and configlet is attached - Deletion process: - if configlet is not part of intended and filter is not matched: we do not remove it - if configlet is not part of intended and filter is matched: we detach configlet. - configlet_filter = ['none'], configet is ignored and not detached Well knows filter value: ------------------------ - 'none': fallback mechanism to merge (no deletion and add everything from intended) - 'all': match all Default value: `configlet_filter=['none']`
github-actions
bot
force-pushed
the
features/cv-containers-delete-configlets
branch
from
March 23, 2020 18:14
1d8b0ab
to
aab295e
Compare
titom73
added a commit
that referenced
this pull request
Apr 3, 2020
- Backport function from #158 - Backport function from #168 - Run Linting - Ansible Linting Linting output: --------------- ``` $ make linting sh .github/pre-commit Validating PEP8 compliance... ------------------------------------------------------------------------------------------------------------ - Modules validation Using config file ansible-cvp/pylintrc -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ------------------------------------------------------------------------------------------------------------ - Module Utils validation Using config file ansible-cvp/pylintrc -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ```
Merged
titom73
removed
state: accepted
Issue is part of the development roadmap
status: in-progress
Currently under investigation or implementation
labels
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: cv_container
Issue related to cv_container module
status: testing
PR under testing
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Related Issue(s)
Proposed changes
cv_container now support option to remove configlet(s) from container by
using a new optional keyword. Meantime, this keyword allows user to also
filter configlets to attach to container
Module Behavior:
ignored
attached
not remove it
detach configlet.
Well knows filter value:
none
: fallback mechanism to merge (no deletion and add everything from intended)all
: match allDefault value: `configlet_filter=['none']
How to test
With tasks:
With tasks:
Checklist:
make linting
andmake sanity-lint
).