Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug L2 interfaces & Channel_Groups set wtih lacp_fallback #1279

Closed
1 task done
ryanmerolle opened this issue Oct 22, 2021 · 1 comment · Fixed by #1335
Closed
1 task done

Bug L2 interfaces & Channel_Groups set wtih lacp_fallback #1279

ryanmerolle opened this issue Oct 22, 2021 · 1 comment · Fixed by #1335
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: accepted Issue is part of the development roadmap type: bug Something isn't working type: enhancement New feature or request

Comments

@ryanmerolle
Copy link
Contributor

Issue Summary

Link #542 given the relation.

When channel_groups are set, no other L2 config is applied which is useful to eliminate L2 redudant config. The problem is when you set LACP fallback individual on the bond, you need to be able to set config parameters on the port.

Why do people need to set fallback? PIXE Boot...

Which component(s) of AVD impacted

eos_cli_config_gen

How do you run AVD ?

Ansible AWX

Steps to reproduce

set channel_group on an interface & lacp_fallback on its associated Port-Channel.

Relevant log output

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@ryanmerolle ryanmerolle added the type: bug Something isn't working label Oct 22, 2021
@ryanmerolle
Copy link
Contributor Author

2 options:

  • Just remove the logic put in place to minimize redundant ethernet interface config since ethernet_interfaces currently have no way of being aware of the port-channel having a fallback configuration - Easy fix, but sort of a breaking change in given everyone who is unware of this current logic would see a ton of redundant config generated once they update to the version that includes the fix
  • Leverage the port_channel_interfaces dictionary to find the parent portchannel and determine if lacp_fallback is configured. Then leverage in the ethernet_interfaces logic with regards to generating the currently hidden config. - Not that hard, but you need to think of data input checks to make sure a parent port-channel exists. Eliminates the breaking change I mentioned above.

@carlbuchmann carlbuchmann added role: eos_designs issue related to eos_designs role role: eos_cli_config_gen issue related to eos_cli_config_gen role type: enhancement New feature or request state: accepted Issue is part of the development roadmap type: bug Something isn't working and removed type: bug Something isn't working labels Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: accepted Issue is part of the development roadmap type: bug Something isn't working type: enhancement New feature or request
Projects
None yet
2 participants