Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface #1335

Merged

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented Nov 16, 2021

Change Summary

In order to use LACP fallback feature, it iw requested that physical interface of a Port-channel has specific and different configuration than the PC itself.
Under this PR, a new validation is set under the ethernet interfaces where a flag is used to decide if configuration under the physical interface must be rendered or not.

Related Issue(s)

Fixes #1279

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

The flag checks if the interface is a Port-channel. If not, flag is activated and configuration is rendered.
If the interface is a Port-channel, it is verified if LACP individual mode is defined. In this case, flag is activated and configuration will be rendered. For normal PC with no LACP fallback individual, flag is not activated and configuration is not rendered.
This is the way that introduces less changes while keeping the previous behaviour.

How to test

Molecule test included

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Nov 16, 2021
@xaviramon xaviramon changed the title Bug (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface Fix (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface Nov 16, 2021
@xaviramon xaviramon changed the title Fix (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface Fix(eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface Nov 16, 2021
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug L2 interfaces & Channel_Groups set wtih lacp_fallback
4 participants