-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface #1335
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
xaviramon:lacp-fallback-bug
Dec 3, 2021
Merged
Fix(eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface #1335
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
xaviramon:lacp-fallback-bug
Dec 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
labels
Nov 16, 2021
xaviramon
changed the title
Bug (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface
Fix (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface
Nov 16, 2021
xaviramon
changed the title
Fix (eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface
Fix(eos_cli_config_gen): Port-channel can use LACP fallback configuration on physical interface
Nov 16, 2021
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tgodaA
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In order to use LACP fallback feature, it iw requested that physical interface of a Port-channel has specific and different configuration than the PC itself.
Under this PR, a new validation is set under the ethernet interfaces where a flag is used to decide if configuration under the physical interface must be rendered or not.
Related Issue(s)
Fixes #1279
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
The flag checks if the interface is a Port-channel. If not, flag is activated and configuration is rendered.
If the interface is a Port-channel, it is verified if LACP individual mode is defined. In this case, flag is activated and configuration will be rendered. For normal PC with no LACP fallback individual, flag is not activated and configuration is not rendered.
This is the way that introduces less changes while keeping the previous behaviour.
How to test
Molecule test included
Checklist
User Checklist
Repository Checklist