Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 interfaces and channel-group bug in cli_config_gen #542

Closed
onurgashi opened this issue Dec 24, 2020 · 3 comments
Closed

L2 interfaces and channel-group bug in cli_config_gen #542

onurgashi opened this issue Dec 24, 2020 · 3 comments
Assignees
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: stale type: bug Something isn't working

Comments

@onurgashi
Copy link
Contributor

Issue Type

  • Bug Report
  • Documentation Issue Report
  • EOS Configuration error

Summary

When we configure channel-group under a port-channel it overrides anything else.
That is desirable to remove redundant configuration, but it should take into account qos, macsec etc) which are configured on physical interface rather than the port-channel level.

{%         if ethernet_interfaces[ethernet_interface].channel_group is defined and ethernet_interfaces[ethernet_interface].channel_group is not none %}
   channel-group {{ ethernet_interfaces[ethernet_interface].channel_group.id }} mode {{ ethernet_interfaces[ethernet_interface].channel_group.mode }}
{%         else %}
{%             if ethernet_interfaces[ethernet_interface].mtu is defined and ethernet_interfaces[ethernet_interface].mtu != 1500 %}
   mtu {{ ethernet_interfaces[ethernet_interface].mtu }}
{%             endif %}

Role or Module Name

eos_cli_config_gen

OS / Environment

EOS Version

Cloudvision version (optional)

OS running Ansible

Steps to reproduce

Expected results

$

Actual results

@onurgashi onurgashi added type: bug Something isn't working role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 24, 2020
@onurgashi onurgashi self-assigned this Dec 29, 2020
@ClausHolbechArista
Copy link
Contributor

I believe QOS is based on port-channel config and not member config. I don't know about the rest of the parameters, so we should probably investigate them one-by-one.
One point though is with port-channel fallback where we use the configuration on the interface during fallback.

@onurgashi
Copy link
Contributor Author

LACP fallback is required, so we need to resolve this.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: stale type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants