Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MACsec with channel-group so it doesn't get overridden from ethernet-interfaces #612

Merged
merged 9 commits into from
Jan 12, 2021
Merged

MACsec with channel-group so it doesn't get overridden from ethernet-interfaces #612

merged 9 commits into from
Jan 12, 2021

Conversation

onurgashi
Copy link
Contributor

Change Summary

With this change we take into account macsec even with channel-group configuration presence under ethernet-interfaces.j2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

#542

Just MACsec part of it, we can still improve fallback stuff.

Component(s) name

eos_cli_config_gen
ethernet-interfaces.j2

Proposed changes

Reorder stuff and edit molecule test case

How to test

Molecule

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@onurgashi onurgashi added type: bug Something isn't working role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jan 12, 2021
@onurgashi onurgashi self-assigned this Jan 12, 2021
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 12, 2021
ClausHolbechArista
ClausHolbechArista approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from ksator January 12, 2021 18:28
onurgashi and others added 9 commits January 12, 2021 21:35
@onurgashi @ClausHolbechArista
macsec precedence before channel-group
610d030
@onurgashi @ClausHolbechArista
Update test case for port-channel macsec
c1b2741
@onurgashi @ClausHolbechArista
Molecule artifacts for macsec test
44f5aa3
@ClausHolbechArista
Update mac-security-eth-po-entropy.yml
5d1de33 
Wrong Indentation and missing newline
@ClausHolbechArista
Update main.yml
0249e77 
Fix missing newline at the end of the file
@ClausHolbechArista
Update ip-routing.j2
1169240 
Remove trailing whitespaces (from rendered markdown)
@ClausHolbechArista
Update tacacs-servers.j2
e198e2f 
Remove trailing whitespaces in generated markdown for various combinations
@ClausHolbechArista
Update vlan-interfaces.j2
6fc7059 
Remove trailing whitespace in generated markdown
@ClausHolbechArista
Update CI
94a9611
carlbuchmann
carlbuchmann approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 5ba863d into aristanetworks:devel Jan 12, 2021
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@titom73 titom73 Awaiting requested review from titom73

@aphillipps aphillipps Awaiting requested review from aphillipps

@ksator ksator Awaiting requested review from ksator

Assignees

@onurgashi onurgashi

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.
4 participants
@onurgashi @carlbuchmann @ClausHolbechArista @titom73