Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add PIM RP addresses on VRF instance #1484

Merged

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Feb 5, 2022

Change Summary

Enhance eos_cli_config_gen pim sparse mode features.

Related Issue(s)

Fixes #1358

Component(s) name

arista.avd.arista.avd.eos_cli_config_gen

Proposed changes

  • Add RP groups definitions under vrf ipv4
router_pim_sparse_mode:
  vrfs:
    - name: < vrf_name >
      ipv4:
        rp_addresses:
          < rp_address_1 >:
            groups:
              < group_prefix_1/mask >:
              < group_prefix_2/mask >:
          < rp_address_2 >:

How to test

See Molecule test case

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested a review from a team as a code owner February 5, 2022 10:00
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 5, 2022
@gusmb gusmb changed the title Added RP addresses on VRF instance Feat(eos_cli_config_gen): Add PIM RP addresses on VRF instance Feb 5, 2022
@tgodaA
Copy link
Contributor

tgodaA commented Feb 6, 2022

Please change your model to:

router_pim_sparse_mode:
  vrfs:
    - name: < vrf_name >
      ipv4:
        rp_addresses:
          - address: < rp_address >
            groups:
              - group_prefix_1/mask
              - group_prefix_2/mask

@gusmb
Copy link
Contributor Author

gusmb commented Feb 6, 2022

Please change your model to:

router_pim_sparse_mode:
  vrfs:
    - name: < vrf_name >
      ipv4:
        rp_addresses:
          - address: < rp_address >
            groups:
              - group_prefix_1/mask
              - group_prefix_2/mask

Data model has been updated accordingly

@gusmb
Copy link
Contributor Author

gusmb commented Feb 8, 2022

I think the CI checks are complaining about something unrelated to this PR...

@tgodaA
Copy link
Contributor

tgodaA commented Feb 8, 2022

That's not your PR issue. I am working on this.

@tgodaA
Copy link
Contributor

tgodaA commented Feb 9, 2022

Please rebase your code and push it again. If it doesn't push the code, use git push with -f option

@gusmb
Copy link
Contributor Author

gusmb commented Feb 9, 2022

Please rebase your code and push it again. If it doesn't push the code, use git push with -f option

Looks OK now

Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA
Copy link
Contributor

tgodaA commented Feb 10, 2022

Thank you for the contribution.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support VRF for multicast_router and router_pim_sparse_mode data models
4 participants