-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add PIM RP addresses on VRF instance #1484
Feat(eos_cli_config_gen): Add PIM RP addresses on VRF instance #1484
Conversation
Please change your model to:
|
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
Data model has been updated accordingly |
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
I think the CI checks are complaining about something unrelated to this PR... |
That's not your PR issue. I am working on this. |
Please rebase your code and push it again. If it doesn't push the code, use git push with |
Looks OK now |
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for the contribution. |
cc1f96f
to
f1495ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change Summary
Enhance eos_cli_config_gen pim sparse mode features.
Related Issue(s)
Fixes #1358
Component(s) name
arista.avd.arista.avd.eos_cli_config_gen
Proposed changes
How to test
See Molecule test case
Checklist
User Checklist
Repository Checklist