-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Allow PIM RP without groups #1528
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
gusmb:issue1521/pim-sparse-mode-rp
Feb 22, 2022
Merged
Feat(eos_cli_config_gen): Allow PIM RP without groups #1528
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
gusmb:issue1521/pim-sparse-mode-rp
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
labels
Feb 20, 2022
...ctions/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tgodaA
reviewed
Feb 21, 2022
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-pim-sparse-mode.j2
Outdated
Show resolved
Hide resolved
tgodaA
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Enhancement for PR #1484
Modify
router_pim_sparse_mode
data model to allow RP definitions without defininggroups
. This allows todefine an RP (inside or outside VRF) that applies to all multicast groups.
Related Issue(s)
Fixes #1521
Related to #1358
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Modified template to render the configuration based on the RP definition, leaving groups as optional:
If
groups
is defined, the RP is defined for those groups, otherwise the RP is defined without groups, which applies by default to ALL multicast groups.How to test
See molecule scenario
Checklist
User Checklist
Repository Checklist