Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Allow PIM RP without groups #1528

Merged

Conversation

gusmb
Copy link
Contributor

@gusmb gusmb commented Feb 20, 2022

Change Summary

Enhancement for PR #1484

Modify router_pim_sparse_mode data model to allow RP definitions without defining groups. This allows to
define an RP (inside or outside VRF) that applies to all multicast groups.

Related Issue(s)

Fixes #1521
Related to #1358

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Modified template to render the configuration based on the RP definition, leaving groups as optional:

{%             for rp_address in vrf.ipv4.rp_addresses | arista.avd.natural_sort('address') %}
{%                 if rp_address.groups is arista.avd.defined and rp_address.groups | length > 0 %}
{%                     for group in rp_address.groups | arista.avd.natural_sort %}
         rp address {{ rp_address.address }} {{ group }}
{%                     endfor %}
{%                 else %}
         rp address {{ rp_address.address }}
{%                 endif %}
{%             endfor %}

If groups is defined, the RP is defined for those groups, otherwise the RP is defined without groups, which applies by default to ALL multicast groups.

How to test

See molecule scenario

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gusmb gusmb requested a review from a team as a code owner February 20, 2022 19:55
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Feb 20, 2022
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista added this to the v3.4.0 milestone Feb 21, 2022
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit e0d6892 into aristanetworks:devel Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small Fix to router_pim_sparse_mode to support VRF RP definition omitting groups
3 participants