Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): interface bfd echo #1571

Merged
merged 17 commits into from
Mar 15, 2022
Merged

Feat(eos_cli_config_gen): interface bfd echo #1571

merged 17 commits into from
Mar 15, 2022

Conversation

ryanmerolle
Copy link
Contributor

Change Summary

Add bfd echo as an option to any bfd configurable interface.

Related Issue(s)

Fixes #1513

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add bfd echo as an option to any bfd configurable interface.

ethernet_interfaces:
  Ethernet1:
    bfd:
      echo: < true | false >
port_channel_interfaces:
  Port-Channel1:
    bfd:
      echo: < true | false >
vlan_interfaces:
  Vlan100:
    bfd:
      echo: < true | false >

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ryanmerolle ryanmerolle requested a review from a team as a code owner March 9, 2022 18:59
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 9, 2022
ClausHolbechArista
ClausHolbechArista reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a column to the table produced in documentation/bfd-interfaces.j2

@ryanmerolle
Copy link
Contributor Author

@ClausHolbechArista

Please add a column to the table produced in documentation/bfd-interfaces.j2

Done

ClausHolbechArista
ClausHolbechArista approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team March 14, 2022 06:39
emilarista
emilarista approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit e0b1ea3 into aristanetworks:devel Mar 15, 2022
@ryanmerolle ryanmerolle deleted the feat_1513 branch March 15, 2022 16:25
@ryanmerolle ryanmerolle mentioned this pull request Mar 15, 2022
Merged
4 tasks
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@xaviramon xaviramon Awaiting requested review from xaviramon

Assignees

@ryanmerolle ryanmerolle

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): interface bfd echo
5 participants
@ryanmerolle @xaviramon @ClausHolbechArista @emilarista @carlbuchmann