Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storm-control to eos_cli_config_gen #306

Closed
wants to merge 7 commits into from
Closed

Add storm-control to eos_cli_config_gen #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a875c8
Implement storm_control as per issue #154
titom73 Oct 23, 2020
34661a0
Update documentation for #154
titom73 Oct 23, 2020
27f6112
Update CI acritfacts
titom73 Nov 28, 2020
7ad571b
Remove unused molecule scenario
titom73 Nov 28, 2020
5c91ebb
Remove base config
titom73 Nov 28, 2020
a3c97d1
Update base config
titom73 Nov 28, 2020
2a62fe5
Trace git diff in CI
titom73 Nov 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/git-repo-state-monitor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ if [[ `git status --porcelain` ]]; then
# No changes
echo 'Some changes'
git status --short
echo 'Diffs are:'
git diff
exit 1
else
# Changes
Expand Down
8 changes: 8 additions & 0 deletions ...ta/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ No VLANs defined
| Interface | Description | MTU | Type | Mode | Allowed VLANs (Trunk) | Trunk Group | VRF | IP Address | Channel-Group ID | Channel-Group Type |
| --------- | ----------- | --- | ---- | ---- | --------------------- | ----------- | --- | ---------- | ---------------- | ------------------ |
| Ethernet1 | P2P_LINK_TO_DC1-SPINE1_Ethernet1 | 1500 | routed | access | - | - | - | 172.31.255.1/31 | - | - |
| Ethernet2 | SRV-POD02_Eth1 | 1500 | switched | trunk | 110-111,210-211 | - | - | - | - | - |
| Ethernet6 | SRV-POD02_Eth1 | 1500 | switched | trunk | 110-111,210-211 | - | - | - | - | - |

*Inherited from Port-Channel Interface
Expand All @@ -234,6 +235,13 @@ interface Ethernet1
no switchport
ip address 172.31.255.1/31
!
interface Ethernet2
description SRV-POD02_Eth1
switchport trunk allowed vlan 110-111,210-211
switchport mode trunk
storm-control all level 10
storm-control broadcast level pps 500
!
interface Ethernet6
description SRV-POD02_Eth1
switchport trunk allowed vlan 110-111,210-211
Expand Down
7 changes: 7 additions & 0 deletions ...llections/arista/avd/molecule/eos_cli_config_gen/intended/configs/ethernet-interfaces.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ interface Ethernet1
no switchport
ip address 172.31.255.1/31
!
interface Ethernet2
description SRV-POD02_Eth1
switchport trunk allowed vlan 110-111,210-211
switchport mode trunk
storm-control all level 10
storm-control broadcast level pps 500
!
interface Ethernet6
description SRV-POD02_Eth1
switchport trunk allowed vlan 110-111,210-211
Expand Down
16 changes: 16 additions & 0 deletions ...ctions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/ethernet-interfaces.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,19 @@ ethernet_interfaces:
mode: trunk
vlans: 110-111,210-211
profile: ALL

Ethernet2:
peer: SRV-POD03
peer_interface: Eth1
peer_type: server
description: SRV-POD02_Eth1
mode: trunk
vlans: 110-111,210-211
profile: ALL
storm_control:
all:
level: 10
unit: percent
broadcast:
level: 500
unit: pps
13 changes: 13 additions & 0 deletions ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,19 @@ ethernet_interfaces:
spanning_tree_bpduguard: < true | false >
spanning_tree_portfast: < edge | network >
vmtracer: < true | false >
storm_control:
all:
level: < Configure maximum storm-control level >
unit: < percent | pps >
broadcast:
level: < Configure maximum storm-control level >
unit: < percent | pps >
multicast:
level: < Configure maximum storm-control level >
unit: < percent | pps >
'unknown-unicast':
level: < Configure maximum storm-control level >
unit: < percent | pps >
```

### Loopback Interfaces
Expand Down
9 changes: 9 additions & 0 deletions ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ interface {{ ethernet_interface }}
{% if ethernet_interfaces[ethernet_interface].vmtracer is defined and ethernet_interfaces[ethernet_interface].vmtracer == true %}
vmtracer vmware-esx
{% endif %}
{% if ethernet_interfaces[ethernet_interface].storm_control is defined and ethernet_interfaces[ethernet_interface].storm_control is not none %}
{% for section in ethernet_interfaces[ethernet_interface].storm_control | arista.avd.natural_sort %}
{% if ethernet_interfaces[ethernet_interface].storm_control[section].unit is defined and ethernet_interfaces[ethernet_interface].storm_control[section].unit == "pps" %}
storm-control {{ section }} level pps {{ethernet_interfaces[ethernet_interface].storm_control[section].level}}
{% else %}
storm-control {{ section }} level {{ethernet_interfaces[ethernet_interface].storm_control[section].level}}
{% endif %}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}
{% endif %}
9 changes: 9 additions & 0 deletions ..._collections/arista/avd/roles/eos_cli_config_gen/templates/eos/port-channel-interfaces.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,14 @@ interface {{ port_channel_interface }}
{% if port_channel_interfaces[port_channel_interface].vmtracer is defined and port_channel_interfaces[port_channel_interface].vmtracer == true %}
vmtracer vmware-esx
{% endif %}
{% if port_channel_interfaces[port_channel_interface].storm_control is defined and port_channel_interfaces[port_channel_interface].storm_control is not none %}
{% for section in port_channel_interfaces[port_channel_interface].storm_control | arista.avd.natural_sort %}
{% if port_channel_interfaces[port_channel_interface].storm_control[section].unit is defined and port_channel_interfaces[port_channel_interface].storm_control[section].unit == "pps" %}
storm-control {{ section }} level pps {{port_channel_interfaces[port_channel_interface].storm_control[section].level}}
{% else %}
storm-control {{ section }} level {{port_channel_interfaces[port_channel_interface].storm_control[section].level}}
{% endif %}
{% endfor %}
{% endif %}
{% endfor %}
{% endif %}