Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storm-control to eos_cli_config_gen #306

Closed
wants to merge 7 commits into from
Closed

Add storm-control to eos_cli_config_gen #306

wants to merge 7 commits into from

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Oct 23, 2020

Change Summary

Add storm-control support to ethernet-interfaces.j2 and port-channel-interfaces.j2.
The port-profile data model can look like:

storm_control:
  <broadcast | multicast | all>:
    level: <storm-control-level>
    unit: <percent | pps>

Types of changes

  • New feature (non-breaking change which adds functionality)

Related Issue(s)

Fixes #154

Component(s) name

eos_cli_config_gen

Proposed changes

Update template to support following data-model:

  <Ethernet_interface_2 >:
    storm_control:
      all:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      broadcast:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      multicast:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      'unknown-unicast':
        level: < Configure maximum storm-control level >
        unit: < percent | pps >

How to test

Update your host-vars to use the data-model described above.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@titom73 titom73 self-assigned this Oct 23, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation labels Oct 23, 2020
@titom73 titom73 changed the title Issues/154 Add storm-control to eos_cli_config_gen Oct 23, 2020
@titom73 titom73 added this to the v1.1.1 milestone Nov 16, 2020
@titom73 titom73 mentioned this pull request Nov 28, 2020
Closed
12 tasks
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 28, 2020
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@titom73
Implement storm_control as per issue #154
4a875c8 
Use Following input data model on either Ethernet Interfaces or Port-Channels:

```
storm_control:
  all:
    level: 10
    unit: pps
  'unknown-unicast':
    level: 1
    unit: percent
```

Output generated:

```
interface Ethernet1
   description P2P_LINK_TO_DC1-SPINE1_Ethernet7
   no switchport
   ip address 172.31.255.17/31
   storm-control all level pps 10
   storm-control unknown-unicast level 1
!
```
@titom73
Update documentation for #154
34661a0
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 28, 2020
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 28, 2020
@github-actions github-actions bot added the type: code quality CI and development toolset label Nov 28, 2020
@titom73 titom73 closed this Nov 28, 2020
@titom73 titom73 deleted the issues/154 branch January 13, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankudinov ankudinov Awaiting requested review from ankudinov

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@titom73 titom73

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Add storm-control support
1 participant
@titom73