Implement defaults for end hosts #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
titom73
changed the title
titom73
requested changes
Nov 28, 2020
| spanning-tree portfast | ||
| {% elif ethernet_interfaces[ethernet_interface].spanning_tree_portfast is defined and ethernet_interfaces[ethernet_interface].spanning_tree_portfast == 'network' %} | ||
| spanning-tree portfast network | ||
| {% elif ethernet_interfaces[ethernet_interface].spanning_tree_portfast is defined and ethernet_interfaces[ethernet_interface].spanning_tree_portfast is not none %} |
There was a problem hiding this comment.
Maybe we can check user configured correct value with a test like:
{% if ethernet_interfaces[ethernet_interface].spanning_tree_portfast in ['auto', 'edge', ''network, 'normal'] %}| spanning-tree portfast | ||
| {% elif port_channel_interfaces[port_channel_interface].spanning_tree_portfast is defined and port_channel_interfaces[port_channel_interface].spanning_tree_portfast == 'network' %} | ||
| spanning-tree portfast network | ||
| {% elif port_channel_interfaces[port_channel_interface].spanning_tree_portfast is defined and port_channel_interfaces[port_channel_interface].spanning_tree_portfast is not none %} |
There was a problem hiding this comment.
Maybe we can check user configured correct value with a test like:
{% if ethernet_interfaces[ethernet_interface].spanning_tree_portfast in ['auto', 'edge', ''network, 'normal'] %}| @@ -105,6 +113,13 @@ interface {{ port_channel_interface }} | |||
| pim ipv4 sparse-mode | |||
| {% endif %} | |||
| {% endif %} | |||
| {% if port_channel_interfaces[port_channel_interface].storm_control is defined and port_channel_interfaces[port_channel_interface].storm_control is not none %} | |||
There was a problem hiding this comment.
Change already covered by PR #306
| @@ -132,6 +132,13 @@ interface {{ ethernet_interface }} | |||
| {% if ethernet_interfaces[ethernet_interface].pim.ipv4.sparse_mode is defined and ethernet_interfaces[ethernet_interface].pim.ipv4.sparse_mode == true %} | |||
| pim ipv4 sparse-mode | |||
| {% endif %} | |||
| {% if ethernet_interfaces[ethernet_interface].storm_control is defined and ethernet_interfaces[ethernet_interface].storm_control is not none %} | |||
There was a problem hiding this comment.
Change already covered by PR #306
| @@ -88,6 +88,14 @@ interface {{ port_channel_interface }} | |||
|
|
|||
| {% endfor %} | |||
| {% endif %} | |||
| {% if port_channel_interfaces[port_channel_interface].lacp_fallback is defined and port_channel_interfaces[port_channel_interface].lacp_fallback is not none %} | |||
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
PR to be updated with:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
closing due to stale PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Types of changes
Related Issue(s)
Fixes #37
Component(s) name
Proposed changes
How to test
Checklist:
pre-commit,make lintingandmake sanity-lint).