-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange generated CLI for traffic-policies
, system
and static-routes
#4590
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4590
# Activate the virtual environment
source test-avd-pr-4590/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@eos-sort-part-8#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,eos-sort-part-8 --force
# Optional: Install AVD examples
cd test-avd-pr-4590
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
dbdd4b2
to
61ef731
Compare
5204954
to
b1fab8c
Compare
Quality Gate passedIssues Measures |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/system.md
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/traffic-policies.j2
Show resolved
Hide resolved
@@ -66,13 +66,13 @@ interface Management1 | |||
system control-plane | |||
tcp mss ceiling ipv4 1344 ipv6 1366 | |||
ip access-group acl4_1 in | |||
ip access-group acl4_3 vrf default in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In running config, the command reflects like - ip access-group acl4_3 in
, if vrf
is default
. Also, vrf
could be default for any one access_group
.
I know, this PR is for ordering only, just noting down here for future enhancements.
@ClausHolbechArista @gmuloc @MaheshGSLAB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I am not sure we can capture this except if we remove the capability not to supply a VRF. I have merged the PR knowing this we can track it in an issue maybe
…licies`, `system` and `static-routes` (aristanetworks#4590)
Change Summary
Rearrange generated CLI for
traffic-policies
,system
andstatic-routes
.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Rearrange generated CLI for
traffic-policies
,system
andstatic-routes
to match with actual EOSHow to test
Run molecule
Checklist
User Checklist
Repository Checklist