Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange generated CLI for traffic-policies, system and static-routes #4590

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Rearrange generated CLI for traffic-policies, system and static-routes.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Rearrange generated CLI for traffic-policies, system and static-routes to match with actual EOS

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Oct 14, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4590
# Activate the virtual environment
source test-avd-pr-4590/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@eos-sort-part-8#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,eos-sort-part-8 --force
# Optional: Install AVD examples
cd test-avd-pr-4590
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 14, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 15, 2024
Copy link

sonarcloud bot commented Oct 17, 2024

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review October 17, 2024 09:58
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners October 17, 2024 09:58
@gmuloc gmuloc merged commit ce3b411 into aristanetworks:devel Oct 17, 2024
46 checks passed
@@ -66,13 +66,13 @@ interface Management1
system control-plane
tcp mss ceiling ipv4 1344 ipv6 1366
ip access-group acl4_1 in
ip access-group acl4_3 vrf default in
Copy link
Contributor

@Shivani-gslab Shivani-gslab Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In running config, the command reflects like - ip access-group acl4_3 in, if vrf is default. Also, vrf could be default for any one access_group.
I know, this PR is for ordering only, just noting down here for future enhancements.
@ClausHolbechArista @gmuloc @MaheshGSLAB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I am not sure we can capture this except if we remove the capability not to supply a VRF. I have merged the PR knowing this we can track it in an issue maybe

gmuloc pushed a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants