Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange generated CLI for
traffic-policies
,system
andstatic-routes
#4590Refactor(eos_cli_config_gen): Rearrange generated CLI for
traffic-policies
,system
andstatic-routes
#4590Changes from all commits
129e440
50c30dd
35e7bc0
56d53e3
b1fab8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In running config, the command reflects like -
ip access-group acl4_3 in
, ifvrf
isdefault
. Also,vrf
could be default forany one access_group
.I know, this PR is for ordering only, just noting down here for future enhancements.
@ClausHolbechArista @gmuloc @MaheshGSLAB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I am not sure we can capture this except if we remove the capability not to supply a VRF. I have merged the PR knowing this we can track it in an issue maybe