Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for "-noaaa" on TerminAttr #508

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add knob under daemon_terminattr to enable -noaaa option.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_cli_config_gen

Proposed changes

Added key to datamodel:

daemon_terminattr:
  ingestgrpcurl:
    ips:
      - < IPv4_address >
      - < IPv4_address >
      - < IPv4_address >
    port: < port_id >
  ingestauth_key: < ingest_key >
  ingestvrf: < vrf_name >
  smashexcludes: "< list as string >"
  ingestexclude: "< list as string >"
  noaaa: < false | true >

How to test

Tested using ClausHolbechArista/claus-l3ls-dev branch superspine-alternative
RS have noaaa:true
SS have noaaa:false
All others have no noaaa specified.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 18, 2020
@titom73
Copy link
Contributor

titom73 commented Dec 18, 2020

Updated artifacts and currently working on eos_l3ls_evpn implementation

@titom73 titom73 added this to the v1.2.0 milestone Dec 18, 2020
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit 6c5fdc0 into aristanetworks:devel Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants