Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disableaaa option for TerminAttr in l3ls_evpn #509

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Support disableaaa option for TerminAttr in l3ls_evpn #509

merged 5 commits into from
Dec 18, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 18, 2020 •
edited by ClausHolbechArista
Loading

Change Summary

Support -disableaaa option in eos_l3ls_evpn

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Follow PR #508

Component(s) name

eos_l3ls_evpn

Proposed changes

# Cloud Vision server
cvp_instance_ips:
  - 192.168.200.11
cvp_ingestauth_key: telarista
terminattr_disable_aaa: true

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 18, 2020
@titom73 titom73 changed the title Support noaaa option for TerminAttr Support noaaa option for TerminAttr in l3ls_evpn Dec 18, 2020
@ClausHolbechArista ClausHolbechArista changed the title Support noaaa option for TerminAttr in l3ls_evpn Support disableaaa option for TerminAttr in l3ls_evpn Dec 18, 2020
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 18, 2020
ClausHolbechArista
ClausHolbechArista approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I have a PR ready to rename from "noaaa" to "disable_aaa"

@ClausHolbechArista ClausHolbechArista merged commit 2b3aaa5 into aristanetworks:devel Dec 18, 2020
@ClausHolbechArista ClausHolbechArista mentioned this pull request Dec 18, 2020
Merged
12 tasks
@titom73 titom73 deleted the features/terminattr-noaaa-l3ls-evpn branch January 13, 2021 08:22
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@titom73 titom73

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @ClausHolbechArista