Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP documentation to include ACL support #599

Merged
merged 5 commits into from
Jan 20, 2021
Merged

SNMP documentation to include ACL support #599

merged 5 commits into from
Jan 20, 2021

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented Jan 11, 2021 •
edited by titom73
Loading

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Jan 11, 2021
@xaviramon
Copy link
Contributor Author

Please, review. Since ACLs on SNMP were not considered as per VRF, this is a breaking change.

onurgashi
onurgashi reviewed Jan 12, 2021
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated
@@ -424,8 +424,16 @@ Redundancy:
snmp_server:
contact: < contact_name >
location: < location >
ipv4_access_list: < ipv4-access-list >
ipv6_access_list: < ipv6-access-list >
ipv4_ACLs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use lowercase everywhere, as that's how we do everything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the catch up!

@titom73 titom73 added this to the v1.2.0 milestone Jan 12, 2021
@onurgashi
Copy link
Contributor

LGTM!

@titom73
Copy link
Contributor

titom73 commented Jan 18, 2021

Doing rebase before merging

@titom73 titom73 added data model change Change to existing data model and removed data model change Change to existing data model labels Jan 18, 2021
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jan 20, 2021
titom73
titom73 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 merged commit abc9388 into aristanetworks:devel Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurgashi onurgashi onurgashi left review comments

@titom73 titom73 titom73 approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@xaviramon xaviramon

Labels
data model change Change to existing data model role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.

ACL support for SNMP
3 participants
@xaviramon @onurgashi @titom73