Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP documentation to include ACL support #599

Merged
merged 5 commits into from
Jan 20, 2021
Merged

SNMP documentation to include ACL support #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e766aad
SNMP documentation to include ACL support
xaviramon Jan 11, 2021
1f347a5
Introducing VRFs definition per ACLs
xaviramon Jan 11, 2021
317817b
Comments on SNMP ACLs
xaviramon Jan 13, 2021
daba87a
Fix md linting issue
titom73 Jan 18, 2021
3517848
Update CI artifacts
titom73 Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions ...ections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/snmp_v3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,18 @@ No logging settings defined

### SNMP Configuration Summary

| Contact | Location | SNMP Traps | IPv4 ACL | IPv6 ACL |
| ------- | -------- | ---------- | -------- | -------- |
| DC1_OPS | DC1 | Enabled | - | - |
| Contact | Location | SNMP Traps |
| ------- | -------- | ---------- |
| DC1_OPS | DC1 | Enabled |

### SNMP ACLs
| IP | ACL | VRF |
| -- | --- | --- |
| IPv4 | SNMP-MGMT | MGMT |
| IPv4 | onur | default |
| IPv6 | SNMP-MGMT | MGMT |
| IPv6 | onur_v6 | default |


### SNMP Local Interfaces

Expand Down Expand Up @@ -255,8 +264,10 @@ No logging settings defined
!
snmp-server contact DC1_OPS
snmp-server location DC1
snmp-server ipv4 access-list SNMP-MGMT vrf MGMT
snmp-server ipv4 access-list onur
snmp-server ipv6 access-list onurv6
snmp-server ipv6 access-list SNMP-MGMT vrf MGMT
snmp-server ipv6 access-list onur_v6
snmp-server vrf MGMT local-interface Management1
snmp-server local-interface Loopback0
snmp-server vrf Tenant_A_APP_Zone local-interface Loopback12
Expand Down
4 changes: 3 additions & 1 deletion ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/snmp_v3.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ hostname snmp_v3
!
snmp-server contact DC1_OPS
snmp-server location DC1
snmp-server ipv4 access-list SNMP-MGMT vrf MGMT
snmp-server ipv4 access-list onur
snmp-server ipv6 access-list onurv6
snmp-server ipv6 access-list SNMP-MGMT vrf MGMT
snmp-server ipv6 access-list onur_v6
snmp-server vrf MGMT local-interface Management1
snmp-server local-interface Loopback0
snmp-server vrf Tenant_A_APP_Zone local-interface Loopback12
Expand Down
10 changes: 8 additions & 2 deletions ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/snmp_v3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ snmp_server:
Loopback0:
Loopback12:
vrf: Tenant_A_APP_Zone
ipv4_access_list: onur
ipv6_access_list: onurv6
ipv4_acls:
- name: SNMP-MGMT
vrf: MGMT
- name: onur
ipv6_acls:
- name: SNMP-MGMT
vrf: MGMT
- name: onur_v6
views:
- name: VW-WRITE
MIB_family_name: iso
Expand Down
10 changes: 8 additions & 2 deletions ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,14 @@ Redundancy:
snmp_server:
contact: < contact_name >
location: < location >
ipv4_access_list: < ipv4-access-list >
ipv6_access_list: < ipv6-access-list >
ipv4_acls:
- name: < ipv4-access-list >
vrf: < vrf >
onurgashi marked this conversation as resolved.
Show resolved Hide resolved
- name: < ipv4-access-list >
ipv6_acls:
- name: < ipv6-access-list >
vrf: < vrf >
- name: < ipv6-access-list >
local_interfaces:
< interface_name_1 >:
vrf: < vrf_name >
Expand Down
21 changes: 18 additions & 3 deletions ..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/snmp-settings.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
{% if snmp_server is defined and snmp_server is not none %}
### SNMP Configuration Summary

| Contact | Location | SNMP Traps | IPv4 ACL | IPv6 ACL |
| ------- | -------- | ---------- | -------- | -------- |
| {{ snmp_server.contact | default('-') }} | {{ snmp_server.location | default('-') }} | {% if snmp_server.traps.enable is defined and snmp_server.traps.enable is not none %}{% if snmp_server.traps.enable %} Enabled {% else %} Disabled {% endif %}{% endif %} | {{ snmp_server.access_list_v4 | default('-') }} | {{ snmp_server.access_list_v6 | default('-') }} |
| Contact | Location | SNMP Traps |
| ------- | -------- | ---------- |
| {{ snmp_server.contact | default('-') }} | {{ snmp_server.location | default('-') }} | {% if snmp_server.traps.enable is defined and snmp_server.traps.enable is not none %}{% if snmp_server.traps.enable %} Enabled {% else %} Disabled {% endif %}{% else %} Disabled {% endif %} |
onurgashi marked this conversation as resolved.
Show resolved Hide resolved

### SNMP ACLs
| IP | ACL | VRF |
| -- | --- | --- |
{% if snmp_server.ipv4_acls is defined and snmp_server.ipv4_acls is not none %}
{% for acl in snmp_server.ipv4_acls %}
| IPv4 | {{ acl.name | default('-') }} | {{ acl.vrf | default('default') }} |
{% endfor %}
{% endif %}
{% if snmp_server.ipv6_acls is defined and snmp_server.ipv6_acls is not none %}
{% for acl in snmp_server.ipv6_acls %}
| IPv6 | {{ acl.name | default('-') }} | {{ acl.vrf | default('default') }} |
{% endfor %}
{% endif %}


### SNMP Local Interfaces

Expand Down
14 changes: 10 additions & 4 deletions ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/snmp-settings.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,17 @@ snmp-server contact {{ snmp_server.contact }}
{% if snmp_server.location is defined and snmp_server.location is not none %}
snmp-server location {{ snmp_server.location }}
{% endif %}
{% if snmp_server.ipv4_access_list is defined and snmp_server.ipv4_access_list is not none %}
snmp-server ipv4 access-list {{ snmp_server.ipv4_access_list }}
{% if snmp_server.ipv4_acls is defined and snmp_server.ipv4_acls is not none %}
{% for acl in snmp_server.ipv4_acls %}
snmp-server ipv4 access-list {{ acl.name }}{% if acl.vrf is defined and acl.vrf is not none %} vrf {{ acl.vrf }} {% endif %}

{% endfor %}
{% endif %}
{% if snmp_server.ipv6_access_list is defined and snmp_server.ipv6_access_list is not none %}
snmp-server ipv6 access-list {{ snmp_server.ipv6_access_list }}
{% if snmp_server.ipv6_acls is defined and snmp_server.ipv6_acls is not none %}
{% for acl in snmp_server.ipv6_acls %}
snmp-server ipv6 access-list {{ acl.name }}{% if acl.vrf is defined and acl.vrf is not none %} vrf {{ acl.vrf }} {% endif %}

{% endfor %}
{% endif %}
{% if snmp_server.local_interfaces is defined and snmp_server.local_interfaces is not none %}
{% for local_interface in snmp_server.local_interfaces %}
Expand Down