Implement role with CV modules in version 3

[titom73]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Documentation content changes
• Other (please describe):

Related Issue(s)

Fixes #924

Component(s) name

• arista.avd.cvp_configlet_upload
• arista.avd.eos_config_deploy_cvp

Proposed changes

Add support of arista.cvp in version 3 by using a knob to select which version to use

# Version of the Cloudvision collection to use for upload
cv_collection: <v1 | v3>

Execution time comparison

• Configlet upload

  • In V1: 1 minutes, 46 seconds
  • In V3: 0 minutes, 11 seconds

• AVD Configuration deploy: Full build AVD+CVP deploy

  • In V1: 3 minutes, 51 seconds
  • In V3: 3 minutes, 5 seconds

Note: In this scenario, there is no additional configlet and additional device configured on Cloudvision side. It might be interesting to compare time in a fully loaded environment.

How to test

Not yet in molecule

Checklist:

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have updated molecule CI testing accordingly
• All new and existing tests passed (pre-commit, make linting and make sanity-lint).

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[noredistribution]

LGTM! Tested this a few good times. Comparison between v1 and v3

v1 results

Thursday 20 May 2021  20:07:09 +0100 (0:00:00.664)       0:10:35.416 **********
===============================================================================
eos_config_deploy_cvp ------------------------------------------------- 607.25s
eos_designs ------------------------------------------------------------ 16.80s
eos_cli_config_gen ----------------------------------------------------- 11.24s
eos_l3ls_evpn ----------------------------------------------------------- 0.05s
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
total ----------------------------------------------------------------- 635.34s
Thursday 20 May 2021  20:07:09 +0100 (0:00:00.664)       0:10:35.415 **********
===============================================================================

v3 results

Friday 21 May 2021  00:41:01 +0000 (0:00:00.036)       0:02:35.131 ************
===============================================================================
eos_config_deploy_cvp ------------------------------------------------- 127.51s
eos_designs ------------------------------------------------------------ 16.27s
eos_cli_config_gen ----------------------------------------------------- 11.28s
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
total ----------------------------------------------------------------- 155.06s
Friday 21 May 2021  00:41:01 +0000 (0:00:00.037)       0:02:35.131 ************
===============================================================================

[guillaumeVilar]

LGTM tested on 2020.3.1:

arista.avd.eos_config_deploy_cvp : Configure devices on cv_server -------------------------------------------- 26.35s
arista.avd.eos_config_deploy_cvp : Building Containers topology on cv_server ------------------------------------------------- 10.60s
arista.avd.cvp_configlet_upload : create configlets on CVP cv_server. --------------------------------------------- 5.06s
arista.avd.eos_config_deploy_cvp : Create configlets on CVP cv_server. -------------------------------------- 4.96s
arista.avd.eos_config_deploy_cvp : Execute pending tasks on cv_server ---------------------- 4.91s
arista.avd.eos_cli_config_gen : Generate content of device documentation ---------------- 3.05s
arista.avd.eos_designs : Generate device configuration in structured format --------------------------- 2.64s
arista.avd.eos_cli_config_gen : Generate eos intended configuration -------------------------------------------- 2.63s
arista.avd.cvp_configlet_upload : generate intented variables -------------------------------- 2.22s
arista.avd.eos_config_deploy_cvp : Generate intented variables ----------------------- 2.20s
arista.avd.eos_designs : Set AVD facts ----------------------------------- 2.12s
arista.avd.eos_designs : Generate fabric documentation in Markdown Format. ------------------- 1.93s
arista.avd.eos_designs : Set AVD topology facts ------------------------- 1.90s
arista.avd.eos_designs : Generate fabric point-to-point links summary in csv format. ----------------------- 1.52s
arista.avd.eos_config_deploy_cvp : Load CVP device information for cv_server --------------------- 1.46s
arista.avd.eos_designs : Generate fabric topology in csv format. --------------------------- 1.31s
arista.avd.eos_cli_config_gen : Generate TOC for device documentation -------------------------- 1.28s
arista.avd.eos_designs : Write device structured configuration to YAML file ---------------- 1.14s
arista.avd.eos_designs : Generate TOC for fabric documentation ----------------- 0.88s
arista.avd.eos_config_deploy_cvp : Build DEVICES and CONTAINER definition for cv_server ------------ 0.82s
Playbook run took 0 days, 0 hours, 1 minutes, 25 seconds

with the playbook:

- hosts: cv_server
  tasks:
    - name: deploy configuration via CVP
      import_role:
         name: arista.avd.eos_config_deploy_cvp
      vars:
        container_root: 'DC1_FABRIC'
        configlets_prefix: 'DC1-AVD'
        device_filter: 'DC1'
        state: present
        execute_tasks: true
        cv_collection: v3

[noredistribution]

LGTM!