Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields tests, and rename XYZParams to XYZConfig for fields #393

Merged
merged 4 commits into from
Feb 20, 2022

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Feb 20, 2022

Description

Fix test generation for Fq12, and also complete renaming of field XYZParams to XYZConfig.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@weikengchen
Copy link
Member

weikengchen commented Feb 20, 2022

Let me add an entry in the CHANGELOG about the renaming of XYZParams to XYZConfig, which I believe is a breaking change.

@weikengchen
Copy link
Member

Pratyush: please see if the CHANGELOG entry is okay, and you may want to change the title of this PR, and then we can merge it.

@Pratyush Pratyush changed the title Add test for Fp12 Add fields tests, and rename XYZParams to XYZConfig for fields Feb 20, 2022
@Pratyush Pratyush merged commit 6ea310e into master Feb 20, 2022
@Pratyush Pratyush deleted the fix-fp12 branch February 20, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants