Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Params to Config & fix test code to new ff #91

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

sunhuachuang
Copy link
Contributor

Description

Upgrade to the latest algebra: arkworks-rs/algebra#393


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

src/bits/uint8.rs Outdated Show resolved Hide resolved
@Pratyush
Copy link
Member

Pratyush commented Mar 1, 2022

This looks good to me; @weikengchen should we merge this into your branch?

@weikengchen
Copy link
Member

Let me take a look. I told Sun to disregard my PR and do the necessary changes all in this one.

@Pratyush Pratyush requested a review from weikengchen March 7, 2022 19:56
@weikengchen
Copy link
Member

Pratyush, I might not be able to do a review. If it looks good, feel free to merge.

@Pratyush
Copy link
Member

Pratyush commented Mar 7, 2022

Sounds good. Should I merge these into your branch, @weikengchen , or into main?

@Pratyush
Copy link
Member

Pratyush commented Mar 7, 2022

Put otherwise, @sunhuachuang, if we point this branch to the appropriate branch on curves, do things compile and pass tests?

@weikengchen
Copy link
Member

I think let us merge it to fix-ff and see if it works.

Sun is in China and will be up in a few hours.

@Pratyush Pratyush merged commit 3b37b33 into arkworks-rs:fix-ff Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants