Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Adding AdditiveGroup and PrimeGroup #159

Merged
merged 7 commits into from
Aug 19, 2023
Merged

Conversation

autquis
Copy link
Contributor

@autquis autquis commented May 12, 2023

See arkworks-rs/algebra#577.

I changed Cargo.toml to avoid redoing what arkworks-rs/r1cs-std#122 has done.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mmaker mmaker requested a review from mmagician May 12, 2023 16:15
@mmagician
Copy link
Member

I would prefer we first merge the r1cs-std PR to not have master here depend on any forks.

@mmaker
Copy link
Member

mmaker commented May 16, 2023

r1cs-std's PR has been merged!

@weikengchen
Copy link
Member

Let me update this PR to see if we can get it ready...

Cargo.toml Show resolved Hide resolved
@drskalman
Copy link
Contributor

@weikengchen: we also need this arkworks-rs/r1cs-std#122, right? bandersnatch tests are failing to compile due to that.

@mmaker
Copy link
Member

mmaker commented Jul 24, 2023

any news on this?

@mmaker
Copy link
Member

mmaker commented Jul 28, 2023

ping.
this is causing problems for the folks at https://github.com/zkCollective/ and I need it for a presentation at DEF CON.

@Pratyush Pratyush merged commit 32b487e into arkworks-rs:master Aug 19, 2023
@slumber slumber mentioned this pull request Aug 19, 2023
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants