Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

patch dependencies and fix imports #167

Merged
merged 3 commits into from
Aug 19, 2023

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Aug 10, 2023

Description

Needed for arkworks-rs/r1cs-std#124

arkworks-rs/algebra#577 broke dependencies in some of arkworks crates.
Specifically, arkworks-rs/r1cs-std#124 requires running tests against
all curves but it doesn't compile. This PR won't compile either because there's a cycle-dependency with r1cs-std.

But merging one would unblock another.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

weikengchen
weikengchen previously approved these changes Aug 19, 2023
@slumber
Copy link
Contributor Author

slumber commented Aug 19, 2023

Not relevant because of #159 I guess

@weikengchen
Copy link
Member

Yes, this would be subsumed by that PR. Shall we close this one?

@weikengchen weikengchen dismissed their stale review August 19, 2023 19:33

Another PR should do the work.

@weikengchen
Copy link
Member

Actually we may still need this PR. We are merging some other PRs and will be back to review this one.

@Pratyush Pratyush merged commit 3fded1f into arkworks-rs:master Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants