-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing SubmitJob with SubmitJobs #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have an endpoint SubmitJob However this is very inefficient when submitting many jobs (which we expect to be common for this application) Also many API calls (one for each SubmitJob) can cause load balancers to throttle connections to the server. I have replaced SubmitJob with SubmitJobs, so you can submit many jobs in a single call - All jobs must belong to the same queue/jobsetid, as specified in the JobSubmitRequest struct)
…properly It is expected this function returns items in the same order it receives them.
This is to make the testdata files match the new submit file format
Fixes #161 |
jankaspar
approved these changes
Nov 5, 2019
svc-gh-ghzonetrans-p
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Move PulsarConfig into common/config (#217) (#3907) * ARMADA-2848 Move PulsarConfig into commonconfig * Update test name TestValidateHasJobSetID->Id * Revert unintended changes to yarn.lock file * fix import order Co-authored-by: Eleanor Pratt <Eleanor.Pratt@gresearch.co.uk> (cherry picked from commit 35cb59f) Signed-off-by: mustaily891 <mustafa.ilyas@gresearch.co.uk> * Adding ControlPlaneEventsTopic to pulsar config --------- Signed-off-by: mustaily891 <mustafa.ilyas@gresearch.co.uk> Co-authored-by: Eleanor Pratt <Eleanor.Pratt@gresearch.co.uk>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have an endpoint SubmitJob
However this is very inefficient when submitting many jobs (which we expect to be common for this application)
Also many API calls (one for each SubmitJob) can cause load balancers to throttle connections to the server.
I have replaced SubmitJob with SubmitJobs, so you can submit many jobs in a single call
I have updated client code to use the new SubmitJobs endpoint