Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing SubmitJob with SubmitJobs #224

Merged
merged 11 commits into from
Nov 5, 2019
Merged

Replacing SubmitJob with SubmitJobs #224

merged 11 commits into from
Nov 5, 2019

Commits on Nov 4, 2019

  1. Replacing SubmitJob with SubmitJobs 

    Currently we have an endpoint SubmitJob

However this is very inefficient when submitting many jobs (which we expect to be common for this application)
Also many API calls (one for each SubmitJob) can cause load balancers to throttle connections to the server.

I have replaced SubmitJob with SubmitJobs, so you can submit many jobs in a single call
 - All jobs must belong to the same queue/jobsetid, as specified in the JobSubmitRequest struct)
    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c12236d View commit details
    Browse the repository at this point in the history

  2. Updating client code (armadactl/armada-load-tester) to submit in bulk

    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    ae1a6f0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bulk-submit

    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    616b208 View commit details
    Browse the repository at this point in the history

  4. Correcting submit_test

    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    55a0523 View commit details
    Browse the repository at this point in the history

  5. Adding tests to confirm submit maintain order on client/server

    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    069a24c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into bulk-submit

    @JamesMurkin
    JamesMurkin authored Nov 4, 2019
    Configuration menu
    Copy the full SHA
    7754845 View commit details
    Browse the repository at this point in the history

  7. Updating job submission yaml files to new structure

    @JamesMurkin
    JamesMurkin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    736ce1f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Making AddJobs return an array rather than map, to maintain ordering … 

    …properly

It is expected this function returns items in the same order it receives them.
    @JamesMurkin
    JamesMurkin committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    e1da201 View commit details
    Browse the repository at this point in the history

  2. Updating client validation testdata file formats 

    This is to make the testdata files match the new submit file format
    @JamesMurkin
    JamesMurkin committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    d1a905f View commit details
    Browse the repository at this point in the history

  3. Fixing test

    @JamesMurkin
    JamesMurkin committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    55a235e View commit details
    Browse the repository at this point in the history

  4. Removing client service package

    @JamesMurkin
    JamesMurkin committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    82a7b88 View commit details
    Browse the repository at this point in the history