-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create linux-libc-dev when building kernel packages #6408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting stuff, thanks for the contribution.
Unfortunately I think this will produce a problem when publishing to apt repos -- different kernels produce the same .deb package name with different contents; if you really need this, you should produce kernel-specific packages (linux-libc-dev-armbian-${BRANCH}-${LINUXFAMILY}
) that Provides: linux-libc-dev
.
Also, what is linux-kernel-headers
?
The way I understand it, libc headers are only useful if you need to rebuild gcc and libc from source yourself and target that specific kernel's features. Since we're using Debian and Ubuntu userspace, built with their glibc, it makes sense to use their headers package, usually corresponding to their "linux-generic" kernel image, no matter what version it was -- the kernel avoids breaking userspace AFAIK.
Would you care to share what is your use-case for the libc headers package? (eg why isn't linux-headers enough?)
@amazingfate for awareness as I know you build glibc (for widevine purposes?), would it benefit from having 35xx's kernels linux-libc-dev package? |
glibc usually doesn't need |
…update control file
Appended
Was taken from the old armbian build scripts (v23.02), i removed it now.
Other than creating this package from the armbian build system there is no way to get those headers in a version matching the armbian kernel. linux-headers always installs linux-libc-dev as a dependency, so it is not enough. headers provided by linux-libc-dev are used by almost all lbraries and programs (e.g. openssl, libc, samba, curl,....) Going through kernel documentationit states [1]: Therefore, the matching headers from linux-libc-dev are required when:
For now we did not notice builds failing because of this but we noticed that linux-libc-dev would stay at version 23.02.2 as it was previously provided by armbian and the debian included version 6.1.76-1 is obviously lower. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description
Added the necessary parts to create linux-libc-dev packages when creating armbian images. This functionality was not added to the new build system but worked just fine up until v23.02.
In my opinion linux-libc-dev should always be created when building an armbian kernel as the kernel versions often differ greatly from the ones natively in the distros (eg. debian bookworm: 6.1.76 vs. armbian current 6.6.21).
Also the armbian package source previously included the package but does not anymore, so the latest updates available were 23.02.2.
See also https://forum.armbian.com/topic/36140-linux-libc-dev-packages-not-available-after-2302/#comment-184962
How Has This Been Tested?
Used the updated scripts to build deb packages and images for bananapi and rpi4b.
The created package linux-libc-dev installs the expected headers.
Checklist: